Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for duplicate header keys containing different values #627

Open
paul678 opened this issue May 16, 2023 · 5 comments
Open
Labels

Comments

@paul678
Copy link

paul678 commented May 16, 2023

We are consuming data from a gRPC backend written with go-grpc. On the server side we have implemented a way to send pack key information inside the trailer metadata which according to this documentation is a map from string to a list of strings.

On the dart client side we where expecting to get all the information placed in that map but found out that the key we where puting info in only contained a single string value after it was received by the dart client. After some digging around we concluded the server implementation is valid and tracked the issue down to a TODO here.

This basically means than if we place multiple strings on the server side we will only map the last one since on Dart we are exposing Map<String, String> in turn breaking our implementation.

@paul678
Copy link
Author

paul678 commented May 16, 2023

Just in case anyone needs it: based on our own customised needs we have forked and fixed the issue here. For now we have not submitted a PR because I'm personally not sure if our fix is following grpc docs or if it's even similar to how this case is covered by other grpc client implementations 🤔

@paul678
Copy link
Author

paul678 commented Aug 31, 2023

Any updates on this issue?

@mosuem
Copy link
Contributor

mosuem commented Aug 31, 2023

Not yet; I can take a look at how to do a non-breaking implementation of this.

@pawelpetruch
Copy link

@mosuem - are there any updates?

@mosuem
Copy link
Contributor

mosuem commented Aug 22, 2024

Not yet - too much on the todo list..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants