Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: add env var protection for client-side security #4247

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Mar 5, 2021

We never got around to protecting client-side security configuration parsing with an env var in gRPC-Go. Better late than never.

Addresses #4245

#grpc-psm-security-client-side

@easwars easwars added the Type: Internal Cleanup Refactors, etc label Mar 5, 2021
@easwars easwars added this to the 1.37 Release milestone Mar 5, 2021
@easwars easwars requested a review from dfawley March 5, 2021 20:28
Comment on lines 575 to 576
sc, err = securityConfigFromCluster(cluster)
if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: you can combine these lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dfawley dfawley assigned easwars and unassigned dfawley Mar 5, 2021
@easwars easwars force-pushed the client_side_security_env_var branch from a7fb22c to 58b842c Compare March 8, 2021 16:28
@easwars easwars force-pushed the client_side_security_env_var branch from 58b842c to 39899c8 Compare March 8, 2021 16:35
@easwars easwars merged commit 19c44c2 into grpc:master Mar 8, 2021
menghanl pushed a commit to menghanl/grpc-go that referenced this pull request Mar 9, 2021
menghanl pushed a commit to menghanl/grpc-go that referenced this pull request Mar 9, 2021
menghanl added a commit that referenced this pull request Mar 11, 2021
Co-authored-by: Easwar Swaminathan <easwars@google.com>

This is a cherry pick of 
- encoding/proto: do not panic when types do not match (#4218)
- xds: add env var protection for client-side security (#4247)
menghanl added a commit that referenced this pull request Mar 11, 2021
Co-authored-by: Easwar Swaminathan <easwars@google.com>

This is a cherry pick of 
- encoding/proto: do not panic when types do not match (#4218)
- xds: add env var protection for client-side security (#4247)
easwars added a commit to easwars/grpc-go that referenced this pull request Mar 25, 2021
@easwars easwars deleted the client_side_security_env_var branch May 5, 2021 21:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants