-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example to illustrate the use of authz
package
#5900
Comments
This issue was partially fixed by #5920, as this PR demonstrated an example through a hardcoded string. The file to watch section still needs to be addressed, as that opens up a different way of technically updating the policy in that case. |
Hi @ginayeh , I can work on this! |
@shashank-priyadarshi -- thanks! Assigning this to you. PS: please make sure that the issue is assigned to you while you are actively working on it. This would make sure we dont have multiple contributors working on the same issue |
Hi @arvindbr8, I would like to contribute. |
@v-sreejith -- Seems like this one is already assigned! Thanks for your interest. |
@v-sreejith -- ping |
@arvindbr8 Hi, can I work on this one if a file watcher example is still needed? I've gone through the existing tests referenced in the issue description and have got a grasp on what this one is about :) |
@Kailun2047 Let us know what you have in mind for the example. Let's have a discussion before you get too deep into actual implementation. Thanks. |
@easwars Sure. I'm thinking about extending the current example a bit. Concretely:
When the example is run, the client will first end up with unexpected PermissionDenied error when requesting with authorized role. Instruct our users to then manually fix the JSON policy file while keep the server running, and start the client again to get the expected responses. Maybe we can also have |
@Kailun2047 : Sounds like a good plan. Looking forward to reviewing your PR. |
We have an authz implementation which is split up as the API and the engine.
The API supports two ways of specifying the authorization policy: as a static string, or as a file to watch. The second method supports online updates to the policy.
We should have examples which illustrates the use of both.
Existing tests can serve as good starting point to understand the usage of the API.
The text was updated successfully, but these errors were encountered: