Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache child policies after deletion only where appropriate #6515

Closed
easwars opened this issue Aug 8, 2023 · 0 comments · Fixed by #6523
Closed

Cache child policies after deletion only where appropriate #6515

easwars opened this issue Aug 8, 2023 · 0 comments · Fixed by #6523
Assignees

Comments

@easwars
Copy link
Contributor

easwars commented Aug 8, 2023

Currently the balancergroup package is used by a bunch of LB policies:

  • priority
  • rls
  • weightedtarget
  • clustermanager

While the balancergroup has functionality to cache removed LB policies for a pre-defined amount of time, this functionality was supposed to be only used by the priority LB policy. But this functionality is currently used by the other policies listed above as well.

We have received reports of an issue where the number of open connections held by the gRPC client is seeing ephemeral increases. This could well be because of the caching of removed LB policies and their subConns, especially given that the clustermanager is the top-level LB policy.

We should make this behavior in the balancergroup configurable with the default behavior being no caching.

@easwars easwars self-assigned this Aug 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant