Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver.Address's BalancerAttributes update will not reflect in Balancer #7124

Closed
LeGamerDc opened this issue Apr 12, 2024 · 3 comments
Closed
Assignees

Comments

@LeGamerDc
Copy link

base.Balancer ignores BalanceAttributes update because it see seem subconn address then not modify its BalancerAttributes.

@dfawley
Copy link
Member

dfawley commented Apr 17, 2024

@LeGamerDc can you explain in more detail what you're trying to do?

@LeGamerDc
Copy link
Author

@dfawley yes, im implement a migrating mechanic. server have some states, and when it go to MIGRATING state, it notify to grpc client through BalancerAttributes, when client know a server is in MIGRATING state, client no longer assign new key to it, and server should shutdown keys one by one.

commonly, if server want to tell client some information about balance strategy, it seems BalancerAttributes is the best choice. and no matter what it tells, grpc should not ignores or rebuild SubConn(if put in Attributes).

i found solution however, write another Balancer is ok.

@dfawley
Copy link
Member

dfawley commented Apr 23, 2024

i found solution however, write another Balancer is ok.

I'm glad you found something that works. If you're still having trouble, then please let us know even more details - what LB policy/policies you're using, what exactly is happening in your code, what you are seeing, and what you are expecting to see.

@dfawley dfawley closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants