Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error for non-default DNS authority. #2067

Merged
merged 2 commits into from Jun 4, 2018
Merged

Throw an error for non-default DNS authority. #2067

merged 2 commits into from Jun 4, 2018

Commits on May 11, 2018

  1. Throw an error for non-default DNS authority. 

    The gRPC naming document at
https://github.com/grpc/grpc/blob/master/doc/naming.md says:

> for DNS, the authority may include the IP[:port] of the DNS server to use

However, grpc-go does not support configuring DNS servers. It will always use
Go's default DNS resolver.
    @jsha
    jsha committed May 11, 2018
    Copy the full SHA
    eb47ed8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2018

  1. Review feedback.

    @jsha
    jsha committed Jun 1, 2018
    Copy the full SHA
    a2ddad9 View commit details
    Browse the repository at this point in the history