transport: do not close channel that can lead to panic #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyuho We were hitting this [0] panic a couple of times and once we have applied this hot fix in etcd v3.3.11 and we haven't gotten any panic so far. |
menghanl
reviewed
Mar 18, 2019
|
@menghanl Done! |
`Write` can be called concurrently, for which it calls the `do` function. As `WriteStatus` can close the `ht.writes` in parallel as well the `Write` will try to write into the `ht.writes` in the `do` function, this can lead into a panic. As there is no real usability on closing this channel we can simply leave it to the garbage collector so we can avoid panic during an execution. Signed-off-by: André Martins <aanm90@gmail.com>
|
It seems master branch is also failing on the same test |
dfawley
changed the title
aanm
added a commit
to aanm/etcd
that referenced
this pull request
Apr 10, 2019
This version includes patch from grpc/grpc-go#2695 which fixes etcd-io#9956 Signed-off-by: André Martins <aanm90@gmail.com>
aanm
added a commit
to aanm/etcd
that referenced
this pull request
Apr 10, 2019
This version includes patch from grpc/grpc-go#2695 which fixes etcd-io#9956 Signed-off-by: André Martins <aanm90@gmail.com>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Apr 12, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.0 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Apr 12, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.0 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
aanm
added a commit
to aanm/etcd
that referenced
this pull request
Apr 23, 2019
This version includes patch from grpc/grpc-go#2695 which fixes etcd-io#9956 Signed-off-by: André Martins <aanm90@gmail.com>
aanm
added a commit
to aanm/etcd
that referenced
this pull request
May 13, 2019
This version includes patch from grpc/grpc-go#2695 which fixes etcd-io#9956 Signed-off-by: André Martins <aanm90@gmail.com>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
May 13, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
May 13, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
May 14, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 28ad54d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
May 14, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 93d76c5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 14, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 93d76c5c9017b8146dcac5f4106e10ba385cce4d Component: cli
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 14, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 28ad54d84f05b789e6a5f9a2ff2a5230d2ec886e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: d371b283c3dd3319350caf23336d6bc93bd5a15d Component: engine
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 14, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 93d76c5c9017b8146dcac5f4106e10ba385cce4d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 57ef4e32f4ee7fac888c5749312f7aa23a11ab7b Component: cli
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 14, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 28ad54d84f05b789e6a5f9a2ff2a5230d2ec886e Component: engine
kiku-jw
pushed a commit
to kiku-jw/moby
that referenced
this pull request
May 16, 2019
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
aanm
added a commit
to aanm/etcd
that referenced
this pull request
May 18, 2019
This version includes patch from grpc/grpc-go#2695 which fixes etcd-io#9956 Signed-off-by: André Martins <aanm90@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writecan be called concurrently, for which it calls thedofunction.As
WriteStatuscan close theht.writesin parallel as well theWritewill try to write into the
ht.writesin thedofunction, this canlead into a panic. As there is no real usability on closing this channel
we can simply leave it to the garbage collector so we can avoid panic
during an execution.
Signed-off-by: André Martins aanm90@gmail.com