Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: do not close channel that can lead to panic #2695

Merged
merged 1 commit into from
Mar 19, 2019
Merged

transport: do not close channel that can lead to panic #2695

merged 1 commit into from
Mar 19, 2019

Commits on Mar 18, 2019

  1. transport: do not close channel that can lean to panic

    `Write` can be called concurrently, for which it calls the `do` function.
    As `WriteStatus` can close the `ht.writes` in parallel as well the `Write`
    will try to write into the `ht.writes` in the `do` function, this can
    lead into a panic. As there is no real usability on closing this channel
    we can simply leave it to the garbage collector so we can avoid panic
    during an execution.
    
    Signed-off-by: André Martins <aanm90@gmail.com>
    aanm committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    589eb9d View commit details
    Browse the repository at this point in the history