-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize generated MethodDescriptor API #1901
Comments
Seems like an API related issue, adding tag for easier searching |
#3618 adds methods for the fields. After giving a little time to convert code over, the fields can be removed. |
API review notes:
|
The current casing behavior seems fine. The snake_casing collision concern is no stronger for this new method than for our existing stub methods. We assume CamelCasing for service names which matches protobuf's generic services. Accepting snake_casing methods and converting them also matches protobuf's generic services. While it is true it can cause collisions if a user uses snake_casing, I think our answer will be "don't do that." Especially since the style guide says to use CamelCase. Because of the style guide, we could conceivably ignore the snake_casing conversion and would still produce the same results as we do today for style-conforming code and avoid collisions for non-conforming code. However, it's not worth the risk to change our pre-existing methods, and there's no gain to change this new API to be different from our current stub methods. |
Today, the generated method descriptors are available as fields. This should probably be changed to be behind a method of some sort so that they can be generated lazily (to reduce static class loading time for Android).
The text was updated successfully, but these errors were encountered: