Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context.Storage is experimental #2462

Open
zhangkun83 opened this issue Nov 30, 2016 · 6 comments · Fixed by #10379
Open

Context.Storage is experimental #2462

zhangkun83 opened this issue Nov 30, 2016 · 6 comments · Fixed by #10379
Assignees
Labels
experimental API Issue tracks stabilizing an experimental API
Milestone

Comments

@zhangkun83
Copy link
Contributor

This is the tracking issue that will be closed once Context.Storage API exits experimental status.

@ejona86 ejona86 added this to the Unscheduled milestone Dec 2, 2016
@ejona86 ejona86 added the experimental API Issue tracks stabilizing an experimental API label Dec 5, 2016
fixmebot bot referenced this issue in aomsw13/develop_test Apr 12, 2021
@larry-safran
Copy link
Contributor

This allows people to change where the values are stored instead of the default ThreadLocal. Used in G3 for ... complex stuff. Also used for other things.
Might want additive changes.

@larry-safran
Copy link
Contributor

Context.Storage.attach() isn't used by anyone in our repo or G3 and can be deleted with Context.Storage.doAttach being marked abstract.

@tonyjongyoonan tonyjongyoonan self-assigned this Jul 12, 2023
@tonyjongyoonan
Copy link
Contributor

tonyjongyoonan commented Jul 12, 2023

On hold since other repos (e.g. Vert.x and OpenTelemetry) depend on Context, may not be safe to delete deprecated method.

@larry-safran
Copy link
Contributor

larry-safran commented Jul 12, 2023

The following query gets all of the usages. Should be checked to ensure that none of them are really using attach .
https://sourcegraph.com/search?q=context:global+class+ContextStorageOverride+lang:java&patternType=standard&sm=0&groupBy=repo

@tonyjongyoonan
Copy link
Contributor

tonyjongyoonan commented Jul 12, 2023

Quarkus.io is the only repo that uses attach().

It is not used anywhere but the override would throw an error if the method is deleted.

@ejona86
Copy link
Member

ejona86 commented Nov 13, 2023

The API is still labeled as experimental.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
experimental API Issue tracks stabilizing an experimental API
Projects
None yet
4 participants