Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepAliveManagerTest should use FakeClock.ScheduledExecutorService #2868

Closed
dapengzhang0 opened this issue Mar 30, 2017 · 1 comment
Closed

KeepAliveManagerTest should use FakeClock.ScheduledExecutorService #2868

dapengzhang0 opened this issue Mar 30, 2017 · 1 comment
Assignees
@voidzcy
Labels
code health
Milestone
1.21

Comments

@dapengzhang0
Copy link
Member

Current tests in KeepAliveManagerTest are using mocked Future and run scheduled task manually, which is not a correct way to test.
@ejona86 ejona86 added this to the Next milestone Jul 27, 2017
@dapengzhang0 dapengzhang0 mentioned this issue Jul 31, 2017
Closed
@dapengzhang0
Copy link
Member Author

#4321

@voidzcy voidzcy mentioned this issue Mar 25, 2019
Merged
@ejona86 ejona86 modified the milestones: Next, 1.21 May 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@voidzcy voidzcy

Labels
code health
Projects
None yet
Milestone
1.21
Development

No branches or pull requests
3 participants
@voidzcy @ejona86 @dapengzhang0