core: use FakeClock.ScheduledExecutorService for KeepAliveManagerTest #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidzcy
force-pushed
the
testfix/keep_alive_manager_test_with_fake_executor
branch
from
e2c142e
to
90f73a3
Compare
dapengzhang0
reviewed
Apr 3, 2019
| } | ||
|
|
||
| @Test | ||
| public void sendKeepAlivePings() { | ||
| ticker.time = 1; | ||
| fakeClock.forwardNanos(1); |
There was a problem hiding this comment.
assertThat(fakeClock.getPendingTasks()).isEmpty() before, and assertThat(fakeClock.getPendingTasks()).hasSize(1) after. You could also use fakeClock.numPendingTasks().
| verify(scheduler, times(2)).schedule(isA(Runnable.class), delayCaptor.capture(), | ||
| isA(TimeUnit.class)); | ||
| delay = delayCaptor.getValue(); | ||
| ScheduledFuture<?> shutdownFuture = Iterables.getFirst(fakeClock.getPendingTasks(), null); |
There was a problem hiding this comment.
assertThat(fakeClock.getPendingTasks()).hasSize(1) first
| // Transport becomes active. We should schedule keepalive pings. | ||
| keepAliveManager.onTransportActive(); | ||
| ArgumentCaptor<Runnable> sendPingCaptor = ArgumentCaptor.forClass(Runnable.class); | ||
| verify(scheduler, times(1)).schedule(sendPingCaptor.capture(), isA(Long.class), |
There was a problem hiding this comment.
Assert number of pendingTasks change.
|
|
||
| // We receive some data. We may need to delay the ping. | ||
| ticker.time = 1500; | ||
| fakeClock.forwardNanos(990); | ||
| keepAliveManager.onDataReceived(); |
There was a problem hiding this comment.
Assert number of pendingTasks unchanged.
| verify(transport, times(0)).ping(isA(ClientTransport.PingCallback.class), | ||
| isA(Executor.class)); | ||
| verify(keepAlivePinger, never()).ping(); | ||
|
|
There was a problem hiding this comment.
Assert number of pendingTasks unchanged.
| ticker.time = 1000; | ||
| sendPing.run(); | ||
| fakeClock.forwardNanos(1000); | ||
|
|
There was a problem hiding this comment.
Also assert number of pending tasks changes. The same for the other tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ScheduledExecutorServiceprovided byFakeClockas the scheduler to runKeepAliveManagerinKeepAliveManagerTest. Also modified hownextKeepaliveTimeis managed inKeepAliveManagerby using a Stopwatch. Solves #2868