core: Convert KeepAliveManager to use Rescheduler #4321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: adjust comments
ejona86
force-pushed
the
keepalivemanager-rescheduler
branch
from
53e830b
to
57fa237
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit more than a POC, but less than a full PR. I know I need to heavily rework comments, for instance. Do we think this is a good change? I feel I should point out I abuse the scheduler with a
scheduler.execute(). That could be fixed by avoiding/having an alternative to Executor in Rescheduler that would return a Runnable.TODO: adjust comments