Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TLS 1.3 for okhttp transport #7431

Open
voidzcy opened this issue Sep 16, 2020 · 2 comments
Open

Support TLS 1.3 for okhttp transport #7431

voidzcy opened this issue Sep 16, 2020 · 2 comments
Labels
enhancement okhttp
Milestone
Next

Comments

@voidzcy
Copy link
Contributor

voidzcy commented Sep 16, 2020

Our current okhttp version (2.7.4 Feb 2016) does not support TLS 1.3

grpc-java/okhttp/third_party/okhttp/main/java/io/grpc/okhttp/internal/ConnectionSpec.java

Line 60 in cb8b067

.tlsVersions(TlsVersion.TLS_1_2, TlsVersion.TLS_1_1, TlsVersion.TLS_1_0)

Okhttp3 supports that. Since we don't have a short-term plan for upgrading to okhttp3, we may consider adding TLS 1.3 support to our existing okhttp transport.
@voidzcy voidzcy added this to the Next milestone Sep 16, 2020
@shrids shrids mentioned this issue Aug 12, 2021
Closed
@tkaitchuck tkaitchuck mentioned this issue Aug 16, 2021
Open
@beatrausch
Copy link
Contributor

Hi, whats the current state of TLS1.3 in grpc?
Regards

@minopolous
Copy link

minopolous commented Sep 28, 2022 •
edited
Loading

Yeah, same question we just fell over connection failures to a service which forces TLS 1.3 and found this ticket here. When specifying the latest TLS1.3 in the tlsconnectionspec call, tls1.3 connection seems to work. Is it just to add the latets version to the default setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement okhttp
Projects
None yet
Milestone
Next
Development

No branches or pull requests
3 participants
@voidzcy @beatrausch @minopolous