fix(grpc-js): Add support for impl type to server.addService

grpc · Aug 31, 2020 · 38e988e · 38e988e
1 parent 4b9da2e
commit 38e988e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/grpc-js/src/server.ts b/packages/grpc-js/src/server.ts
@@ -144,9 +144,14 @@ export class Server {
     throw new Error('Not implemented. Use addService() instead');
   }
 
-  addService(
-    service: ServiceDefinition,
-    implementation: UntypedServiceImplementation
+  addService<
+    ImplementationType extends Record<
+      string,
+      UntypedHandleCall
+    > = UntypedServiceImplementation
+  >(
+    service: ServiceDefinition<ImplementationType>,
+    implementation: ImplementationType
   ): void {
     if (this.started === true) {
       throw new Error("Can't add a service to a started server.");

diff --git a/packages/grpc-js/test/test-server.ts b/packages/grpc-js/test/test-server.ts
@@ -181,7 +181,7 @@ describe('Server', () => {
       const server = new Server();
 
       assert.throws(() => {
-        server.addService({}, dummyImpls);
+        server.addService({} as any, dummyImpls);
       }, /Cannot add an empty service to a server/);
     });