Fails to build with node.js v12.0.0 release #834

mdouglass · 2019-04-23T22:11:29Z

Problem description

../ext/channel.cc:292:56: error: too few arguments to function call, expected 2, have 1
  int try_to_connect = (int)info[0]->Equals(Nan::True());
                            ~~~~~~~~~~~~~~~            ^
/Users/mdouglass/.node-gyp/12.0.0/include/node/v8.h:2572:3: note: 'Equals' declared here
  V8_WARN_UNUSED_RESULT Maybe<bool> Equals(Local<Context> context,
  ^
/Users/mdouglass/.node-gyp/12.0.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))

Reproduction steps

npm init
npm install grpc@latest

Environment

macOS 10.14.4
node.js v12.0.0 installed via macOS installer from nodejs.org
gRPC 1.20.0

Additional context

Attached log files
2019-04-23T22_09_12_791Z-debug.log
console.log

The text was updated successfully, but these errors were encountered:

sangaman · 2019-04-24T07:19:29Z

Same issue on Ubuntu 19.04, node 12.0.0 installed with nvm, grpc 1.18.0.

This disables the travis build for the current Node.js version (12.0.0) until all dependencies support it. See: grpc/grpc-node#834

nicolasnoble · 2019-04-24T17:10:56Z

We are working on getting 1.20.1 out with node 12 support, stay tuned.

murgatroid99 · 2019-04-26T19:46:58Z

grpc@1.20.1 is now out with Node 12 support.

murgatroid99 · 2019-04-26T22:08:51Z

Update: we had to unpublish 1.20.1 because it broke the TypeScript types. 1.20.2 will be out soon.

aaaguirrep · 2019-04-27T12:10:56Z

I have the next issue with nodejs 12.0 when it runs npm rebuild, is it the same issue?

3585 error code ELIFECYCLE
3586 error errno 1
3587 error grpc@1.20.0 install: `node-pre-gyp install --fallback-to-build --library=static_library`
3587 error Exit status 1
3588 error Failed at the grpc@1.20.0 install script.
3588 error This is probably not a problem with npm. There is likely additional logging output above.
3589 verbose exit [ 1, true ]

nicolasnoble · 2019-04-27T12:32:36Z

@aaaguirrep you haven't provided nearly enough information for us to tell if that's the case, but it most likely is, since it's 100% impossible to use grpc with node 12 at the moment.

murgatroid99 · 2019-04-29T16:38:38Z

version 1.20.2 is now out.

aaaguirrep · 2019-04-29T23:23:12Z

What is the process to upgrade gprc? I not see the new release in the repositorie.

sangaman · 2019-04-29T23:26:05Z

What is the process to upgrade gprc?

npm install grpc@1.20.2 should work.

aaaguirrep · 2019-04-29T23:33:13Z

It worked, I dont see errors running npm rebuild

nicolasnoble · 2019-04-30T01:23:28Z

Closing as resolved.

aaaguirrep · 2019-04-30T02:27:36Z

does it work for yarn? I am having an issue upgrading or installing the new release but i am not sure if the issue is with grpc or other dependencies.

nicolasnoble · 2019-04-30T14:19:06Z

Our yarn support always has been best effort. We don't officially support it.

cekvenich · 2019-05-01T13:24:04Z

FYI this is used in FireBase and they still ship the old version that does not work w/ Node v12.
I use FireBase and that is why I'm here. Now I'm monkey patching package.json to replace what FireBase ships.

nicolasnoble · 2019-05-01T13:53:35Z

I would suggest filling an issue with firebase then.

cekvenich · 2019-05-01T13:56:47Z

I would love to - but I don't know how/where. I went on their website and filed a comment and sent a message to their group. The stack trace shows that the version they released TODAY is using the older version of grpc. I use 40 npm modules at least 10 are native and the only one w/ that does not work is Google Firebase. And no way to flag them or do PR.

nicolasnoble · 2019-05-01T14:14:02Z

https://github.com/firebase/firebase-js-sdk

cekvenich · 2019-05-01T14:14:53Z

THANK YOU.

aaaguirrep · 2019-05-01T14:41:31Z

I am also using firebase in my project and it shows the issue. I thought that issue was related to yarn.

cekvenich · 2019-05-01T15:02:30Z

@aaaguirrep please upvote firebase/firebase-js-sdk#1738

grpc/grpc-node#834

EngAhmedShehatah · 2019-06-10T15:02:48Z

npm ERR! grpc@1.20.0 install: node-pre-gyp install --fallback-to-build --library=static_library
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the grpc@1.20.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I'm trying to use ( npm install ) to install a project node_modules
node -v = v12.4.0
npm -v = 6.9.0
angular 8

gr-butler · 2019-06-20T08:32:09Z

Same issue:

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! grpc@1.20.2 install: node-pre-gyp install --fallback-to-build --library=static_library
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the grpc@1.20.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm -v
6.9.0
node -v
v10.16.0
(fedora 29)

murgatroid99 · 2019-06-20T16:51:29Z

Please post the entire error message, or at least the first several lines.

gr-butler · 2019-06-20T17:22:46Z

This issue seemed to be closed so opened #922

EngAhmedShehatah · 2019-06-22T19:28:47Z

grpc@1.20.0 install /home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc
node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp WARN Tried to download(404): https://node-precompiled-binaries.grpc.io/grpc/v1.20.0/node-v72-linux-x64-glibc.tar.gz
node-pre-gyp WARN Pre-built binaries not found for grpc@1.20.0 and node@12.4.0 (node-v72 ABI, glibc) (falling back to source compile with node-gyp)
gyp ERR! build error
gyp ERR! stack Error: not found: make
gyp ERR! stack at getNotFoundError (/usr/lib/node_modules/npm/node_modules/which/which.js:13:12)
gyp ERR! stack at F (/usr/lib/node_modules/npm/node_modules/which/which.js:68:19)
gyp ERR! stack at E (/usr/lib/node_modules/npm/node_modules/which/which.js:80:29)
gyp ERR! stack at /usr/lib/node_modules/npm/node_modules/which/which.js:89:16
gyp ERR! stack at /usr/lib/node_modules/npm/node_modules/isexe/index.js:42:5
gyp ERR! stack at /usr/lib/node_modules/npm/node_modules/isexe/mode.js:8:5
gyp ERR! stack at FSReqCallback.oncomplete (fs.js:165:21)
gyp ERR! System Linux 4.18.0-22-generic
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--library=static_library" "--module=/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/src/node/extension_binary/node-v72-linux-x64-glibc/grpc_node.node" "--module_name=grpc_node" "--module_path=/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/src/node/extension_binary/node-v72-linux-x64-glibc" "--napi_version=4" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v72"
gyp ERR! cwd /home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc
gyp ERR! node -v v12.4.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/usr/bin/node /usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --library=static_library --module=/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/src/node/extension_binary/node-v72-linux-x64-glibc/grpc_node.node --module_name=grpc_node --module_path=/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/src/node/extension_binary/node-v72-linux-x64-glibc --napi_version=4 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
node-pre-gyp ERR! stack at ChildProcess. (/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack at ChildProcess.emit (events.js:200:13)
node-pre-gyp ERR! stack at maybeClose (internal/child_process.js:1021:16)
node-pre-gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
node-pre-gyp ERR! System Linux 4.18.0-22-generic
node-pre-gyp ERR! command "/usr/bin/node" "/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build" "--library=static_library"
node-pre-gyp ERR! cwd /home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc
node-pre-gyp ERR! node -v v12.4.0
node-pre-gyp ERR! node-pre-gyp -v v0.12.0
node-pre-gyp ERR! not ok
Failed to execute '/usr/bin/node /usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --library=static_library --module=/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/src/node/extension_binary/node-v72-linux-x64-glibc/grpc_node.node --module_name=grpc_node --module_path=/home/ahmed/Documents/alghanim-phase2-frontend/node_modules/grpc/src/node/extension_binary/node-v72-linux-x64-glibc --napi_version=4 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
npm WARN @ng-bootstrap/ng-bootstrap@4.2.1 requires a peer of rxjs@^6.3.0 but none is installed. You must install peer dependencies yourself.
npm WARN @ngtools/webpack@6.0.8 requires a peer of typescript@~2.4.0 || ~2.5.0 || ~2.6.0 || ~2.7.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-in-memory-web-api@0.6.1 requires a peer of @angular/common@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-in-memory-web-api@0.6.1 requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-in-memory-web-api@0.6.1 requires a peer of @angular/http@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular2-csv@0.2.9 requires a peer of @angular/common@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular2-csv@0.2.9 requires a peer of @angular/core@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN The package @angular/compiler is included as both a dev and production dependency.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/webpack-dev-server/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/watchpack/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/rijs.resdir/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/karma/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.0.7 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.0.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/@schematics/update/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/@schematics/angular/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/@angular/compiler-cli/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/@angular/cli/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/@angular-devkit/schematics/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/@angular-devkit/core/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! grpc@1.20.0 install: node-pre-gyp install --fallback-to-build --library=static_library
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the grpc@1.20.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

EngAhmedShehatah · 2019-06-22T19:31:38Z

Dear Grpc/Grpc-Node Team, Sorry for the late reply. I have commented with the full error text from the very beginning. If you need info about my system or any other info just let me know. Thanks in advance and I am looking forward to hearing from you. Best Regards, *Ahmed Mohammed Shehatah* Front-End Web Developer Email: engahmedshehatah@gmail.com Mobile: +201005363688

…

On Thu, Jun 20, 2019 at 7:22 PM pointer2null ***@***.***> wrote: This issue seemed to be closed so opened #922 <#922> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#834?email_source=notifications&email_token=AJNQHEFQZVD5YOI76U6KJVLP3O4GXA5CNFSM4HH6ZQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYGCERQ#issuecomment-504111686>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJNQHEAROTBQUCPCF5GICIDP3O4GXANCNFSM4HH6ZQ2Q> .

murgatroid99 · 2019-06-24T17:16:53Z

You are using a version of the grpc library that does not support Node 12. Please use either a newer version of grpc or an older version of Node.

tdeleanu · 2019-07-10T07:53:10Z

Same issue.
Had to upgrade to "grpc": "^1.20.2".

AHPanna · 2019-09-15T20:13:33Z

i just downgrade node (10.9.0), and fixed for now.

ghonaimeg · 2019-10-24T10:48:20Z

I have the next issue with nodejs 12.0 when it runs npm rebuild, is it the same issue?

3585 error code ELIFECYCLE
3586 error errno 1
3587 error grpc@1.20.0 install: `node-pre-gyp install --fallback-to-build --library=static_library`
3587 error Exit status 1
3588 error Failed at the grpc@1.20.0 install script.
3588 error This is probably not a problem with npm. There is likely additional logging output above.
3589 verbose exit [ 1, true ]

how you solve it

gr-butler · 2019-10-24T10:52:48Z

see #922 for workaround

safciplak · 2019-11-12T17:42:01Z

What is the process to upgrade gprc?

npm install grpc@1.20.2 should work.

Thanks it's working

Vichet97 · 2019-12-13T08:28:36Z

can you tell me the command to list all development environment ?
Is it react-native info ?

Firebase js client appears to have a dependency problem grpc/grpc-node#834 Firebase issue tracker is a bit quiet about it, but installing grpc by hand might work.

murgatroid99 mentioned this issue Apr 23, 2019

Native: fix Node 12 compilation errors #835

Merged

sangaman added a commit to ExchangeUnion/xud that referenced this issue Apr 24, 2019

chore: disable current v12 node travis build

cbf44bd

This disables the travis build for the current Node.js version (12.0.0) until all dependencies support it. See: grpc/grpc-node#834

sangaman mentioned this issue Apr 24, 2019

chore: disable current v12 node travis build ExchangeUnion/xud#902

Merged

DRoet mentioned this issue Apr 26, 2019

support node.js 12 grpc/grpc#18849

Closed

mattkrick mentioned this issue Apr 26, 2019

Bump grpc to support node 12 ParabolInc/parabol#2832

Closed

1 task

louistiti mentioned this issue Apr 28, 2019

I cant install Leon ELIFECYCLE ERROR (Node.js 12) leon-ai/leon#85

Closed

phaze9 mentioned this issue Apr 28, 2019

Update to node 10.x, npm 6.4.x, webpack 4.4.27, webpack-dev-server 3.1.5 and firebase 5.10.1 WuTheFWasThat/vimflowy#311

Merged

nicolasnoble closed this as completed Apr 30, 2019

ma53 mentioned this issue Apr 30, 2019

Update grpc to 1.20.2 microsoft/etcd3#93

Closed

cekvenich mentioned this issue May 1, 2019

FB does not work w/ Node v12 firebase/firebase-js-sdk#1738

Closed

Leko added a commit to Leko/shotshell-journal that referenced this issue May 2, 2019

chore: upgrade firebase to support Node.js 12

a6f8aed

grpc/grpc-node#834

mfrohberg mentioned this issue May 2, 2019

Bugfix/grpc error aretecode/modern-stack-web-portfolio#69

Merged

daikw mentioned this issue May 3, 2019

firebaseでauth daikw/spajam-2019B#1

Open

EECOLOR mentioned this issue May 6, 2019

Node gyp build fails on node v12.1.0 nodejs/node-gyp#1733

Closed

haoyangnz mentioned this issue Sep 16, 2019

Fails to build with node v12 boardgameio/boardgame.io#463

Closed

Chizzoz mentioned this issue Oct 8, 2019

Getting npm ERR! Failed at the grpc@1.20.0 install script. wilfredmulenga/project-zed#35

Closed

jpawlowski mentioned this issue Oct 22, 2019

Node.js v12 compatibility fhempy/gassistant-fhem#1

Closed

chibicode mentioned this issue Jan 14, 2020

npm install fails with firebase example "with-firebase-authentication" vercel/next.js#10092

Closed

lock bot locked as resolved and limited conversation to collaborators Mar 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fails to build with node.js v12.0.0 release #834

Fails to build with node.js v12.0.0 release #834

mdouglass commented Apr 23, 2019

sangaman commented Apr 24, 2019

nicolasnoble commented Apr 24, 2019

murgatroid99 commented Apr 26, 2019

murgatroid99 commented Apr 26, 2019

aaaguirrep commented Apr 27, 2019

nicolasnoble commented Apr 27, 2019

murgatroid99 commented Apr 29, 2019

aaaguirrep commented Apr 29, 2019

sangaman commented Apr 29, 2019

aaaguirrep commented Apr 29, 2019

nicolasnoble commented Apr 30, 2019

aaaguirrep commented Apr 30, 2019

nicolasnoble commented Apr 30, 2019

cekvenich commented May 1, 2019

nicolasnoble commented May 1, 2019

cekvenich commented May 1, 2019

nicolasnoble commented May 1, 2019

cekvenich commented May 1, 2019

aaaguirrep commented May 1, 2019

cekvenich commented May 1, 2019

EngAhmedShehatah commented Jun 10, 2019

gr-butler commented Jun 20, 2019

murgatroid99 commented Jun 20, 2019

gr-butler commented Jun 20, 2019

EngAhmedShehatah commented Jun 22, 2019

EngAhmedShehatah commented Jun 22, 2019 via email

murgatroid99 commented Jun 24, 2019

tdeleanu commented Jul 10, 2019

AHPanna commented Sep 15, 2019 •

edited

Loading

ghonaimeg commented Oct 24, 2019

gr-butler commented Oct 24, 2019

safciplak commented Nov 12, 2019

Vichet97 commented Dec 13, 2019

Fails to build with node.js v12.0.0 release #834

Fails to build with node.js v12.0.0 release #834

Comments

mdouglass commented Apr 23, 2019

Problem description

Reproduction steps

Environment

Additional context

sangaman commented Apr 24, 2019

nicolasnoble commented Apr 24, 2019

murgatroid99 commented Apr 26, 2019

murgatroid99 commented Apr 26, 2019

aaaguirrep commented Apr 27, 2019

nicolasnoble commented Apr 27, 2019

murgatroid99 commented Apr 29, 2019

aaaguirrep commented Apr 29, 2019

sangaman commented Apr 29, 2019

aaaguirrep commented Apr 29, 2019

nicolasnoble commented Apr 30, 2019

aaaguirrep commented Apr 30, 2019

nicolasnoble commented Apr 30, 2019

cekvenich commented May 1, 2019

nicolasnoble commented May 1, 2019

cekvenich commented May 1, 2019

nicolasnoble commented May 1, 2019

cekvenich commented May 1, 2019

aaaguirrep commented May 1, 2019

cekvenich commented May 1, 2019

EngAhmedShehatah commented Jun 10, 2019

gr-butler commented Jun 20, 2019

murgatroid99 commented Jun 20, 2019

gr-butler commented Jun 20, 2019

EngAhmedShehatah commented Jun 22, 2019

EngAhmedShehatah commented Jun 22, 2019 via email

murgatroid99 commented Jun 24, 2019

tdeleanu commented Jul 10, 2019

AHPanna commented Sep 15, 2019 • edited Loading

ghonaimeg commented Oct 24, 2019

gr-butler commented Oct 24, 2019

safciplak commented Nov 12, 2019

Vichet97 commented Dec 13, 2019

AHPanna commented Sep 15, 2019 •

edited

Loading