Fails to build with node.js v12.0.0 release

[mdouglass]

Problem description

../ext/channel.cc:292:56: error: too few arguments to function call, expected 2, have 1
  int try_to_connect = (int)info[0]->Equals(Nan::True());
                            ~~~~~~~~~~~~~~~            ^
/Users/mdouglass/.node-gyp/12.0.0/include/node/v8.h:2572:3: note: 'Equals' declared here
  V8_WARN_UNUSED_RESULT Maybe<bool> Equals(Local<Context> context,
  ^
/Users/mdouglass/.node-gyp/12.0.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))

Reproduction steps

npm init
npm install grpc@latest

Environment

• macOS 10.14.4
• node.js v12.0.0 installed via macOS installer from nodejs.org
• gRPC 1.20.0

Additional context

Attached log files
2019-04-23T22_09_12_791Z-debug.log
console.log

[sangaman]

Same issue on Ubuntu 19.04, node 12.0.0 installed with nvm, grpc 1.18.0.

[nicolasnoble]

We are working on getting 1.20.1 out with node 12 support, stay tuned.

[murgatroid99]

grpc@1.20.1 is now out with Node 12 support.

[murgatroid99]

Update: we had to unpublish 1.20.1 because it broke the TypeScript types. 1.20.2 will be out soon.

[aaaguirrep]

I have the next issue with nodejs 12.0 when it runs npm rebuild, is it the same issue?

3585 error code ELIFECYCLE
3586 error errno 1
3587 error grpc@1.20.0 install: `node-pre-gyp install --fallback-to-build --library=static_library`
3587 error Exit status 1
3588 error Failed at the grpc@1.20.0 install script.
3588 error This is probably not a problem with npm. There is likely additional logging output above.
3589 verbose exit [ 1, true ]

[nicolasnoble]

@aaaguirrep you haven't provided nearly enough information for us to tell if that's the case, but it most likely is, since it's 100% impossible to use grpc with node 12 at the moment.

[murgatroid99]

version 1.20.2 is now out.

[aaaguirrep]

What is the process to upgrade gprc? I not see the new release in the repositorie.