Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native core subtree graft. #11

Merged
merged 1,008 commits into from
Sep 11, 2017
Merged

Native core subtree graft. #11

merged 1,008 commits into from
Sep 11, 2017

Conversation

nicolasnoble
Copy link
Member

No description provided.

nicolasnoble and others added 30 commits August 20, 2016 01:45
Upmerge doc changes from v1.0.x
Compiles with npm install --debug option.
…ction

Remove deprecated V8 function call in Node library
The node interop client was checking that the status message for
the test unimplemented_method was an empty string. This behavior
is not guaranteed, and thus the check should be removed.
@murgatroid99 murgatroid99 mentioned this pull request Aug 31, 2017
13 tasks
@kjin
Copy link
Contributor

kjin commented Sep 5, 2017

Would you want to include package.json and binding.gyp in this as well?

@nicolasnoble
Copy link
Member Author

Updated the PR with the latest commits from the origin repository. The only change was the version number.

@kjin: we'll do these changes in subsequent PRs. This is really about moving history back in here.

@kjin
Copy link
Contributor

kjin commented Sep 11, 2017

Ok - I thought you'd want to preserve the history of package.json and binding.gyp as well.

Is there anything you'd want me to double-check? IE is this PR meant to be reviewable?

@murgatroid99 murgatroid99 merged commit dc76b51 into grpc:master Sep 11, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet