Native core subtree graft - attempt #2 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upmerge doc changes from v1.0.x
Compiles with npm install --debug option.
…emented_method test for node
…ction Remove deprecated V8 function call in Node library
The node interop client was checking that the status message for the test unimplemented_method was an empty string. This behavior is not guaranteed, and thus the check should be removed.
New python interop tests
Fix missing return after callback in a function
Fix racy Node reconnect test
Bump to version 1.4.0
It appears that omitting it causes grpc to use the hosts' default cert data. This was brought up (as I had implemented this method incorrectly) in: microsoft/etcd3#28 (comment)
…egfault Node: fix segfault with incorrect status argument types
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing #11 since I apparently messed up.