Bump protobuf submodule dep of grpc-tools #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry for the delay. Did you bump the submodule to a specific release tag and if so, which one? |
I'm trying to think back and I'm not sure; it's been a bit. It might have been to the top of master. I'd like to go back and bump it to the latest stable, 3.11.4. Could we merge that? |
|
The latest stable release sounds to me like a good point to bump to. |
|
Awesome. Should be good to go. |
murgatroid99
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency hasn't been updated for almost two years and the jspbs
generated are out of sync with the docs. Specifically, none of the
setters return the message so chaining isn't possible.