Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use bundledDependencies #1371

Merged
merged 1 commit into from May 7, 2020

Conversation

@Naktibalda
Copy link
Contributor

@Naktibalda Naktibalda commented Apr 20, 2020

node-pre-gyp doesn't recommend using bundledDependencies anymore:

Note: in the past we recommended putting node-pre-gyp in the bundledDependencies, but we no longer recommend this. In the past there were npm bugs (with node versions 0.10.x) that could lead to node-pre-gyp not being available at the right time during install (unless we bundled). This should no longer be the case. Also, for a time we recommended using "preinstall": "npm install node-pre-gyp" as an alternative method to avoid needing to bundle. But this did not behave predictably across all npm versions - see mapbox/node-pre-gyp#260 for the details. So we do not recommend using preinstall to install node-pre-gyp. More history on this at fsevents/fsevents#157 (comment).

The particular issue I want to solve is that the usage of bundledDependencies prevents deduping and updating of dependencies of node-pre-gyp, e.g. #1363

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Apr 20, 2020

CLA Check
The committers are authorized under a signed CLA.

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Thank you for your contribution

@murgatroid99 murgatroid99 merged commit ed608f8 into grpc:master May 7, 2020
9 of 12 checks passed
@Naktibalda Naktibalda deleted the dont-use-bundledDependencies branch Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants