Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js: support adding/removing services on started server #1614

Merged
merged 3 commits into from Oct 29, 2020
Merged

grpc-js: support adding/removing services on started server #1614

merged 3 commits into from Oct 29, 2020

Conversation

hugebdu
Copy link
Contributor

@hugebdu hugebdu commented Oct 29, 2020

This PR includes:

  • removing the requirement of Server#addService(...) for non-started server
  • adding Server#unregister(...) and Server#removeService(...) - the counterparts of Server#register(...) and Server#addService

workaround for #1547

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 29, 2020 •
edited

CLA Check
The committers are authorized under a signed CLA.

@hugebdu hugebdu mentioned this pull request Oct 29, 2020
Closed
murgatroid99
murgatroid99 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@murgatroid99 murgatroid99 merged commit d8021d2 into grpc:master Oct 29, 2020
@murgatroid99
Copy link
Member

This is now out in version 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugebdu @murgatroid99 @kokoro-team