Fix a credentials plugin test to match changes in core #90
Conversation
|
It actually looks like that if we merge this PR first, not tests will be broken (as this accepts both UNAVAILABLE and UNAUTHENTICATED) - so we can merge this first and then merge grpc/grpc#13363? |
|
@murgatroid99, I checked the test results for grpc/grpc#13363 and the UNAUTHENTICATED -> UNAVAILABLE change is the only breakage there. So it seems it's ready to merge after this PR is merged. |
|
As I said, this submodule update points to your PR instead of to master. I don't want to merge in that state. This shows that the tests will pass, so as soon as you merge your PR, I can update the submodule reference in this one and merge it. |
|
Ah, ok, get it now. Feel free to proceed. Thanks!
…On Nov 15, 2017 19:33, "Michael Lumish" ***@***.***> wrote:
As I said, this submodule update points to your PR instead of to master. I
don't want to merge in that state. This shows that the tests will pass, so
as soon as you merge your PR, I can update the submodule reference in this
one and merge it.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#90 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJeq5IqKwta6VnA2c2XzDW2zC1GfSXNnks5s2y50gaJpZM4QeLyv>
.
|
|
@murgatroid99 any progress here? we've had this PR and grpc/grpc#13363 around for a while now. |
|
As I said before, I am waiting for you to merge your PR before I merge this one. |
|
Thanks! |
This currently points to the PR that makes the core change. It will need to be modified to point to grpc/grpc master instead before it is merged.