Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Switching from UNAUTHENTICATED to UNAVAILABLE for auth metadata failure"" #13363

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Revert "Revert "Switching from UNAUTHENTICATED to UNAVAILABLE for auth metadata failure"" #13363

merged 2 commits into from
Jan 16, 2018

Conversation

jtattermusch
Copy link
Contributor

Reverts #13346.

Adds back the original #13322, but this time we need to merge after updating all the tests accordingly.

@jtattermusch
Copy link
Contributor Author

jtattermusch commented Nov 13, 2017 •
edited

CC @jboeuf @ejona86 @yang-g

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

jboeuf
jboeuf approved these changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@jboeuf jboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much!

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch mentioned this pull request Nov 13, 2017
Closed
@jtattermusch
Copy link
Contributor Author

grpc/grpc-node#88 needs to be merged first.

@jtattermusch jtattermusch mentioned this pull request Nov 15, 2017
Merged
@jtattermusch
Copy link
Contributor Author

Known failures:
#13122

@jtattermusch
Copy link
Contributor Author

I checked the tests results and this is ready to merge after grpc/grpc-node#90 goes in.

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch force-pushed the revert-13346-revert-13322-oauth_failure branch from 638c40c to a2044f8 Compare December 13, 2017 23:18
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@jtattermusch
Copy link
Contributor Author

Known failures:
#13149.

@jtattermusch jtattermusch merged commit e5b7ddd into master Jan 16, 2018
@jtattermusch
Copy link
Contributor Author

The temporary breakage of node tests will be fixed by @murgatroid99 soon.

@stanley-cheung
Copy link
Contributor

This also seems to have broken PHP unit tests on the 1.8.5 release somehow.

@nicolasnoble nicolasnoble deleted the revert-13346-revert-13322-oauth_failure branch January 19, 2018 23:01
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jboeuf jboeuf jboeuf approved these changes

Assignees

@jboeuf jboeuf

@yang-g yang-g

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jtattermusch @grpc-testing @stanley-cheung @jboeuf @yang-g @kokoro-team