Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit from #385 breaks d.ts proto generation #401

Closed
weilip1803 opened this issue Nov 30, 2018 · 3 comments
Closed

Commit from #385 breaks d.ts proto generation #401

weilip1803 opened this issue Nov 30, 2018 · 3 comments

Comments

@weilip1803
Copy link

weilip1803 commented Nov 30, 2018

#385 adds typings to all the getters and setters. But currently files that only contain messages do not generate d.ts typings. And services which import from such files do not get the types of such files as they are not being generated.

To reproduce. Just have 2 proto file. 1) Proto A contains the service and some message that requires to import from proto b. 2) Proto b which only contain messages.

@shaxbee
Copy link
Contributor

shaxbee commented Jan 12, 2019

@weilip Could you check if #433 fixes your problem?

@weilip1803
Copy link
Author

weilip1803 commented Jan 13, 2019

Thanks for the fix. I am on holiday I will check it on Thursday when I am back

@shaxbee
Copy link
Contributor

shaxbee commented Jan 25, 2019

This should be now resolved in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants