Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy cors enabled field deprecated #614

Closed
isthisangela-zz opened this issue Aug 20, 2019 · 2 comments
Closed

envoy cors enabled field deprecated #614

isthisangela-zz opened this issue Aug 20, 2019 · 2 comments

Comments

@isthisangela-zz
Copy link

https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated#version-1-10-0-apr-5-2019

^ the latest version of envoy deprecates "Use of enabled in CorsPolicy, found in route.proto. Set the filter_enabled field instead."

It looks like the cors fields in the envoy.yaml examples should be updated from enabled: true to something like

filter_enabled:
    default_value:
        numerator: 100
        denominator: HUNDRED
@stanley-cheung
Copy link
Collaborator

We have fixed some of those at #593 and #595. Looks like there's one more place we need to fix: https://github.com/grpc/grpc-web/blob/master/net/grpc/gateway/examples/helloworld/README.md

@stanley-cheung
Copy link
Collaborator

Fixed in #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stanley-cheung @isthisangela-zz