Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly generate code if package name is empty #310

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Oct 5, 2018

Fixes #306.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution!

@stanley-cheung stanley-cheung merged commit a312d85 into grpc:master Oct 5, 2018
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

If you make any changes to it yourself then they will take precedence over the rebase.

---

[//]: # (dependabot-end)

Bumps [browserstack-local](https://github.com/browserstack/browserstack-local-nodejs) from 1.3.4 to 1.3.7.
<details>
<summary>Release notes</summary>

*Sourced from [browserstack-local's releases](https://github.com/browserstack/browserstack-local-nodejs/releases).*

> ## Locked ps-tree version to 1.1.1
> This library has a dependency on ps-tree, which has a dependency on event-stream which had a security bug in newer versions.
> Hence locked ps-tree's version to 1.1.1 which uses event-stream's secure version 3.3.4
> 
> For more details, please refer:
> indexzero/ps-tree#33
> dominictarr/event-stream#116
> 
> ## Changed local binary paths to support LocalBinary 7.3. Fixed folder argument.
> Changed local binary paths to support LocalBinary 7.3. 
> Fixed folder argument when building browserstack local arguments.
</details>
<details>
<summary>Commits</summary>

- [`230ec93`](browserstack/browserstack-local-nodejs@230ec93) Merge pull request [grpc#66](https://github-redirect.dependabot.com/browserstack/browserstack-local-nodejs/issues/66) from punitx/lock_ps_tree_version
- [`2c74310`](browserstack/browserstack-local-nodejs@2c74310) Bumped package version to 1.3.7
- [`0c5043f`](browserstack/browserstack-local-nodejs@0c5043f) Locked ps-tree version to 1.1.1
- [`e1f22d5`](browserstack/browserstack-local-nodejs@e1f22d5) Revert "Merge pull request [grpc#65](https://github-redirect.dependabot.com/browserstack/browserstack-local-nodejs/issues/65) from yohan-pereira/remove_pstree"
- [`dfea668`](browserstack/browserstack-local-nodejs@dfea668) Merge pull request [grpc#65](https://github-redirect.dependabot.com/browserstack/browserstack-local-nodejs/issues/65) from yohan-pereira/remove_pstree
- [`caf72de`](browserstack/browserstack-local-nodejs@caf72de) Revert "Overriding stop method for fixing stop local issue in docker [grpc#56](https://github-redirect.dependabot.com/browserstack/browserstack-local-nodejs/issues/56)"
- [`5fec9d5`](browserstack/browserstack-local-nodejs@5fec9d5) Merge pull request [grpc#63](https://github-redirect.dependabot.com/browserstack/browserstack-local-nodejs/issues/63) from browserstack/version_bump
- [`f03131c`](browserstack/browserstack-local-nodejs@f03131c) Version Bump
- [`ad3e3de`](browserstack/browserstack-local-nodejs@ad3e3de) Merge pull request [grpc#62](https://github-redirect.dependabot.com/browserstack/browserstack-local-nodejs/issues/62) from browserstack/fix-folder-flg
- [`5a5a32a`](browserstack/browserstack-local-nodejs@5a5a32a) Fix argument order sent via command line to browserstack local binary.
- Additional commits viewable in [compare view](browserstack/browserstack-local-nodejs@v1.3.4...1.3.7)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=browserstack-local&package-manager=npm_and_yarn&previous-version=1.3.4&new-version=1.3.7)](https://dependabot.com/compatibility-score.html?dependency-name=browserstack-local&package-manager=npm_and_yarn&previous-version=1.3.4&new-version=1.3.7)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @easyCZ.

[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated invalid code
3 participants