Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Switching from UNAUTHENTICATED to UNAVAILABLE for auth metadata failure" #13346

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

jtattermusch
Copy link
Contributor

Reverts #13322

The PR changes call statuses without updating tests for all languages. There are breakages at least in C#, Ruby and PHP (on all platforms).

E.g. in c#

1) Failed : Grpc.IntegrationTesting.MetadataCredentialsTest.MetadataCredentials_InterceptorThrows
  Expected: Unauthenticated
  But was:  Unavailable
at Grpc.IntegrationTesting.MetadataCredentialsTest.MetadataCredentials_InterceptorThrows()

@grpc-testing
Copy link

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link

[trickle] No significant performance differences

@grpc-testing
Copy link

[microbenchmarks] No significant performance differences

@jtattermusch
Copy link
Contributor Author

Merging early to fix the breakage.

@jtattermusch jtattermusch merged commit 9c34c78 into master Nov 10, 2017
@jtattermusch
Copy link
Contributor Author

@jboeuf, feel free to recreate the PR and ask others to create PRs against your branch to update tests for wrapped languages before the new PR gets merged (but the updates should be fairly trivial - e.g. for C# it's a change of an assertion)

@jboeuf
Copy link
Contributor

jboeuf commented Nov 10, 2017

@jtattermusch sorry for the breakage. Would you (or someone else from the gRPC team) mind recreating the PR and fix the different languages? I'm really swamped now. Thanks much.
@ejona86 FYI.

@ejona86 ejona86 deleted the revert-13322-oauth_failure branch November 10, 2017 18:07
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
@lock lock bot unassigned dgquintas Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants