Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 13793 to 1.8.x #13921

Merged
merged 1 commit into from Jan 5, 2018
Merged

Backport 13793 to 1.8.x #13921

merged 1 commit into from Jan 5, 2018

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Jan 4, 2018

I'd like +to backport this to 1.8.x so that I can verify #13910 with the distrib tests.

@apolcyn apolcyn requested a review from mehrdada January 4, 2018 23:21
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@apolcyn
Copy link
Contributor Author

apolcyn commented Jan 5, 2018 •
edited

test failures appear to be mostly fixed on master.
basic tests linux c: #13124
basic tests c++ linux: #12958
basic tests c++ #13430
tsan c: #13351
tsan c++: #13591
mac c++: #11116 (unimplementedrpc)

@apolcyn apolcyn merged commit 82eebaf into grpc:v1.8.x Jan 5, 2018
@apolcyn apolcyn mentioned this pull request Jan 5, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
@lock lock bot unassigned mehrdada Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehrdada mehrdada mehrdada approved these changes

Assignees
No one assigned
Labels
lang/ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apolcyn @grpc-testing @mehrdada