mitigate gcc8 -Wstringop-truncation and -Wignored-qualifiers #14452
Conversation
|
|
|
|
any updates on this? Is it worth to invest some time to rebase and resolve the conflicts? |
|
amended fixes for -Werror=class-memaccess (as well appearing with gcc8) |
|
since some distros now ship gcc8, did anybody have a look at this, yet? |
|
I am still willing to update this - though I would need some feedback in case there is something off. #15443 has another solution to this issue. Could anyone comment please @dgquintas @nicolasnoble |
|
updated to master |
|
can anybody please comment how to proceed with this one @dgquintas @nicolasnoble @vjpai ? |
|
Does this PR address |
|
no it does not, which compiler and version do you use? |
|
since I just updated this branch, I am using (each in a separate commit) |
|
@toanju This is a build issue more than a compile one. I am on This could be fixable by patching the makefile, but I don't know how to do that when |
|
Same error as this guy: #15520 so it is not specific to Gentoo or to gcc 8.2.0. Gentoo has a number of gcc8-related patches: https://gitweb.gentoo.org/repo/gentoo.git/tree/net-libs/grpc/files but because this is pulled from rubygems these would not be applied. This is also on a significantly newer ruby version (2.4) and grpc (1.15.0) |
|
Nice to see that the patches here helped at least the Gentoo folks. With regards to your ruby build @matoro I am not sure what the best procedure is to fix this. In general I'd say this has to be fixed in the c-ares repo and then the ref here should be updated. |
|
The problem is that this flag is added somewhere downstream, not in the vanilla c-ares build. Looking at line 10252 of the grpc makefile, I would think that it would only be added if a mingw environment is detected, but I cannot find anywhere else in the build stream that this flag is mentioned. |
|
Rebased to master. Even if it's almost a year I am looking for feedback. |
AspirinSJL
added
the
release notes: no
|
@nicolasnoble Friendly reminder. |
example error:
src/cpp/common/channel_filter.cc:33:48: error: ‘void* memset(void*, int,
size_t)’ clearing an object of non-trivial type ‘grpc_linked_mdelem’
{aka ‘struct grpc_linked_mdelem’}; use assignment or
value-initialization instead [-Werror=class
-memaccess]
memset(storage, 0, sizeof(grpc_linked_mdelem));
^
In file included from ./src/core/lib/transport/transport.h:34,
from ./src/core/lib/channel/channel_stack.h:48,
from src/cpp/common/channel_filter.cc:21:
./src/core/lib/transport/metadata_batch.h:33:16: note:
‘grpc_linked_mdelem’ {aka ‘struct grpc_linked_mdelem’} declared here
typedef struct grpc_linked_mdelem {
^~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 180 days. It will be closed automatically if no further update occurs in 1 day. Thank you for your contributions! |
this PR deals with the warnings of gcc8