-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compilation bug on gcc 8.1.0 #15443
Conversation
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
@recolic thanks for the contribution, and it looks good to me, but before we can accept it, we need you to sign the CLA as the bot mentions. |
|
|
|
@nicolasnoble CLA signed...... |
Cleaning up old PRs. If this is still something you want to pursue, please re-open. |
@markdroth Is this issue resolved? |
Not as far as I know. If you'd still like to pursue it, please reopen the PR and make sure there are no merge conflicts with master, and we can take a look. |
I tried
git clone https://github.com/grpc/grpc && cd grpc && make -j4
with gcc 8.1.0(ArchLinux) and I got many compilation bugs. So I tried to fix them.