Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation bug on gcc 8.1.0 #15443

Closed
wants to merge 2 commits into from
Closed

fix compilation bug on gcc 8.1.0 #15443

wants to merge 2 commits into from

Conversation

recolic
Copy link

@recolic recolic commented May 18, 2018

I tried git clone https://github.com/grpc/grpc && cd grpc && make -j4 with gcc 8.1.0(ArchLinux) and I got many compilation bugs. So I tried to fix them.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@nicolasnoble
Copy link
Member

@recolic thanks for the contribution, and it looks good to me, but before we can accept it, we need you to sign the CLA as the bot mentions.

@grpc-testing
Copy link

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link

[trickle] No significant performance differences

@grpc-testing
Copy link

[microbenchmarks] No significant performance differences

@recolic
Copy link
Author

recolic commented May 18, 2018

@nicolasnoble CLA signed......

@markdroth
Copy link
Member

Cleaning up old PRs. If this is still something you want to pursue, please re-open.

@markdroth markdroth closed this Feb 12, 2019
@recolic
Copy link
Author

recolic commented Feb 13, 2019

@markdroth Is this issue resolved?

@markdroth
Copy link
Member

Not as far as I know. If you'd still like to pursue it, please reopen the PR and make sure there are no merge conflicts with master, and we can take a look.

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants