Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checking for hotplugged CPUs in gpr_cpu_current_cpu for linux #14712

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Add checking for hotplugged CPUs in gpr_cpu_current_cpu for linux #14712

merged 1 commit into from
Mar 14, 2018

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Mar 14, 2018 •
edited

Fixes #14711 by defaulting to 0 if it's a hotplugged CPU

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                     FILE SIZE
 ++++++++++++++ GROWING                       ++++++++++++++
  +0.0%     +59 [None]                            +83  +0.0%
   +23%     +69 src/core/lib/gpr/cpu_linux.cc     +69   +23%
       +77%     +69 gpr_cpu_current_cpu               +69   +77%

  +0.0%    +128 TOTAL                            +152  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@yashykt yashykt mentioned this pull request Mar 14, 2018
Closed
@yashykt yashykt requested a review from sreecha March 14, 2018 19:03
@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

sreecha
sreecha approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@sreecha sreecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome find Yash!.

@yashykt yashykt merged commit 3681ca3 into grpc:master Mar 14, 2018
@yashykt yashykt deleted the hotplugcpu branch March 14, 2018 22:14
@dependabot-preview dependabot-preview bot mentioned this pull request Jul 2, 2018
Merged
@BusyJay BusyJay mentioned this pull request Sep 27, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreecha sreecha sreecha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yashykt @grpc-testing @sreecha