Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unlimited as the max receive message length #15394

Merged
merged 2 commits into from
Jun 8, 2018
Merged

Allow unlimited as the max receive message length #15394

merged 2 commits into from
Jun 8, 2018

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented May 15, 2018 •
edited

Allow unlimited as the max receive message length
Fixes #13553

@yashykt yashykt requested a review from vjpai May 15, 2018 23:40
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@yashykt
Copy link
Member Author

yashykt commented Jun 8, 2018

Known issues : #15610 and previously existing docker issues

@yashykt yashykt merged commit bbbcc45 into grpc:master Jun 8, 2018
@yashykt yashykt mentioned this pull request Jun 8, 2018
Closed
@yashykt yashykt added the release notes: yes Indicates if PR needs to be in release notes label Jun 12, 2018
@dependabot-preview dependabot-preview bot mentioned this pull request Jul 4, 2018
Merged
@yashykt yashykt deleted the maxmsglen branch October 26, 2018 20:53
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vjpai vjpai vjpai approved these changes

Assignees

@vjpai vjpai

Labels
release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yashykt @grpc-testing @vjpai