Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GRPCCall refcounting issue #16213

Merged
merged 3 commits into from
Aug 10, 2018
Merged

Fix GRPCCall refcounting issue #16213

merged 3 commits into from
Aug 10, 2018

Conversation

muxi
Copy link
Member

@muxi muxi commented Aug 1, 2018

  • When a call is to be finished, no further access to the same GRPCCall instance should be allowed since the self retain might be already gone and the object can be dealloc'ed.
  • NSNotificationCenter is holding a weak reference to GRPCCall object. Make a strong reference in notification callback to make behaviors more predictable.

Fix #16045

@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,980,459      Total (<)      1,980,471

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,810,803      Total (>)     10,810,797

 No significant differences in binary sizes


@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,980,507      Total (>)      1,980,479

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,810,796      Total (>)     10,810,794

 No significant differences in binary sizes


@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,981,758      Total (>)      1,981,730

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,814,016      Total (>)     10,814,015

 No significant differences in binary sizes


@muxi muxi added the release notes: yes Indicates if PR needs to be in release notes label Aug 7, 2018
@muxi
Copy link
Member Author

muxi commented Aug 10, 2018

Interop ALTS Tests - #16203
InteropCloud-to-Cloud Tests - #13379

@muxi muxi merged commit d1a1739 into grpc:master Aug 10, 2018
@muxi muxi deleted the fix-ios8-con-mon branch August 10, 2018 22:24
@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2018
@lock lock bot unassigned makdharma Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang/ObjC release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants