-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure libboringssl.a
is always built for Python
#17049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidizheng
added
kind/bug
lang/Python
release notes: yes
Indicates if PR needs to be in release notes
labels
Oct 29, 2018
|
Seems like macos aftifacts are failing :-) |
|
* This commit failed `tools/run_tests/artifacts/build_artifact_csharp.sh` * It doesn't make any sense!
|
* reduce possible contamination of environment variables
|
Go is not installed (Artifact Build MacOS (internal CI)):
|
|
|
Interestingly, this trunk of code specified for macOS was introduced by #10427. |
nicolasnoble
approved these changes
Oct 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #17002
After discussing with @nicolasnoble , it is important to keep the BoringSSL inside the gRPC Python distribution. It is much easier to link inside the Python distribution than linking to the system's library, and may potentially create problems in Windows. So, instead of risking to build upon arbitrary dependencies, it seems more sensible to ensure
libboringssl.a
is always built for gRPC Python.