Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure libboringssl.a is always built for Python #17049

Merged
merged 6 commits into from
Oct 31, 2018

Conversation

lidizheng
Copy link
Contributor

Issue #17002

After discussing with @nicolasnoble , it is important to keep the BoringSSL inside the gRPC Python distribution. It is much easier to link inside the Python distribution than linking to the system's library, and may potentially create problems in Windows. So, instead of risking to build upon arbitrary dependencies, it seems more sensible to ensure libboringssl.a is always built for gRPC Python.

@lidizheng lidizheng added kind/bug lang/Python release notes: yes Indicates if PR needs to be in release notes labels Oct 29, 2018
@lidizheng lidizheng self-assigned this Oct 29, 2018
@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,303      Total (=)      2,015,303

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,115,479      Total (<)     11,115,482

 No significant differences in binary sizes


@nicolasnoble
Copy link
Member

Seems like macos aftifacts are failing :-)

@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,303      Total (=)      2,015,303

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,115,999      Total (>)     11,115,995

 No significant differences in binary sizes


* This commit failed `tools/run_tests/artifacts/build_artifact_csharp.sh`
* It doesn't make any sense!
@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,303      Total (=)      2,015,303

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,115,993      Total (<)     11,115,994

 No significant differences in binary sizes


* reduce possible contamination of environment variables
@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,303      Total (=)      2,015,303

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,115,993      Total (>)     11,115,986

 No significant differences in binary sizes


@Mottl
Copy link

Mottl commented Oct 30, 2018

Go is not installed (Artifact Build MacOS (internal CI)):

CMake Error at third_party/boringssl/CMakeLists.txt:38 (message):
304
  Could not find Go

@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,649      Total (=)      2,015,649

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,116,198      Total (>)     11,116,193

 No significant differences in binary sizes


@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,649      Total (=)      2,015,649

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,116,196      Total (>)     11,116,189

 No significant differences in binary sizes


@lidizheng
Copy link
Contributor Author

Interestingly, this trunk of code specified for macOS was introduced by #10427.

@lidizheng lidizheng merged commit 5a8b5e8 into grpc:master Oct 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug lang/Python platform/macOS release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants