PHP: attempt to add v1.21.4 to interop matrix #19228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley-cheung
added
lang/php
release notes: no
|
#19230 would need to be backported to make this PR work. |
This was referenced Jun 6, 2019
stanley-cheung
force-pushed
the
php-add-release-to-matrix
branch
from
424922b
to
e7cb1f0
Compare
stanley-cheung
changed the title
stanley-cheung
force-pushed
the
php-add-release-to-matrix
branch
from
e7cb1f0
to
cd591f0
Compare
|
@jtattermusch This is ready for another review. The Adhoc interop matrix job was succesful - I manually triggered another build, PTAL. Thanks. |
| @@ -281,8 +281,7 @@ def __init__(self, patch=[], runtimes=[], testcases_file=None): | |||
| ('v1.16.0', ReleaseInfo(testcases_file='php__v1.0.1')), | |||
| ('v1.17.1', ReleaseInfo(testcases_file='php__v1.0.1')), | |||
| ('v1.18.0', ReleaseInfo()), | |||
| # TODO:https://github.com/grpc/grpc/issues/18264 | |||
There was a problem hiding this comment.
Please leave a comment why v1.19 an v1.20 are missing so it's obvious this is not a mistake.
jtattermusch
approved these changes
Jun 11, 2019
stanley-cheung
force-pushed
the
php-add-release-to-matrix
branch
from
cd591f0
to
e92622e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.