Hotfix for PHP jwt_token_creds interop test #19230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
added
lang/php
release notes: yes
|
Filed #19231 to track a proper fix. |
stanley-cheung
approved these changes
Jun 6, 2019
This was referenced Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've investigated more why PHP jwt token creds test behaves differently than in other languages and found the reason.
As a side effect, this should fix the problem we're seeing in #19228 (but it's basically a workaround that makes PHP behave like the other languages so the "port resolved to 0" problem is not triggered).