Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C++ code generation to work with Bazel 0.29 . #19860

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Update C++ code generation to work with Bazel 0.29 . #19860

merged 1 commit into from
Aug 12, 2019

Commits on Aug 6, 2019

  1. Update C++ code generation to work with Bazel 0.29 . 

    The above Bazel version changes proto compilation slightly: some proto
files are put into a `_virtual_imports` directory and thus
`_get_include_directory` needs to be updated accordingly.

Ideally, it would use instead the `ProtoInfo` provider to tease out the
proto import directories, but that's a bit more intrusive change.
    @lberki
    lberki committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    e2ba3aa View commit details
    Browse the repository at this point in the history