Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding gcc8 portability test. #20009

Closed
wants to merge 2 commits into from
Closed

Adding gcc8 portability test. #20009

wants to merge 2 commits into from

Conversation

nicolasnoble
Copy link
Member

So we stop the pain.

@nicolasnoble nicolasnoble added the release notes: no Indicates if PR should not be in release notes label Aug 20, 2019
jtattermusch
jtattermusch approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the gcc 8.3 fixes need to be done before merging (portability tests suite needs to pass).

@stale
Copy link

stale bot commented Mar 15, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 180 days. It will be closed automatically if no further update occurs in 1 day. Thank you for your contributions!

@stale stale bot closed this Mar 22, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hcaseyal hcaseyal hcaseyal approved these changes

@jtattermusch jtattermusch jtattermusch approved these changes

@apolcyn apolcyn Awaiting requested review from apolcyn apolcyn is a code owner

Assignees

@hcaseyal hcaseyal

Labels
disposition/stale release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasnoble @hcaseyal @jtattermusch