Add GRPC_ARG_HTTP_PROXY channel argument. #20866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the GRPC_ARG_HTTP_PROXY channel argument so that HTTP proxy settings can be controlled per channel.
klfreeman
requested review from
apolcyn,
AspirinSJL and
markdroth
as code owners
|
|
markdroth
reviewed
Oct 30, 2019
markdroth
added
kokoro:run
lang/core
release notes: yes
- Clarify comments - Simplify code by using grpc_channel_args_find_string function
|
Sorry for the delay; this somehow slipped off my radar. The changes look good, but it looks like there's a merge conflict to address. |
|
I've resolved the merge conflicts, noticed that one of the Sanity Checks was failing, and fixed the formatting error. Hopefully should be ready to merge now. |
yashykt
approved these changes
Dec 27, 2019
markdroth
approved these changes
Jan 6, 2020
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
|
Yash, can you please check the tests and get this merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the GRPC_ARG_HTTP_PROXY channel argument so that HTTP proxy
settings can be controlled per channel.
@yashykt