Add version check for Python 3.6 to simple stubs #22549
Conversation
gnossen
added
kind/bug
lang/Python
release notes: no
|
This was also hitting some of our own CI (the Go xDS tests on master, but I think it's just luck other workers haven't been using 3.5 as well). |
| @@ -85,6 +85,6 @@ def _wrapper(*args, **kwargs): | |||
| 'insecure_channel_credentials', | |||
| ) | |||
|
|
|||
| if sys.version_info[0] >= 3: | |||
| if sys.version_info[0] == 3 and sys.version_info[1] >= 6: | |||
There was a problem hiding this comment.
If you remove the f-string, then we can support 3.6 users. Simple stubs can be available to more users.
There was a problem hiding this comment.
True. This was originally a middle-of-the-night quick fix. Now that the pressure is off, I'll take some time to try to extend support back to 3.5.
There was a problem hiding this comment.
Sure. Claim supporting 3.5 might need extra efforts.
There was a problem hiding this comment.
Lidi, I took another look at this and the problem is more than just f-strings. It's also PEP 526 variable annotations that don't work in 3.5. I think it's reasonable to have the same interpreter requirements as our asyncio support, namely, 3.6+.
There was a problem hiding this comment.
Sorry... I mean, to securely claim 3.5 is properly supported. We will need the infrastructure that we discussed today. Manual tests might work for now, but might not protect this environment in the future. So, I agree that a separate PR is better than try to support 3.5 in this one.
| @@ -85,6 +85,6 @@ def _wrapper(*args, **kwargs): | |||
| 'insecure_channel_credentials', | |||
| ) | |||
|
|
|||
| if sys.version_info[0] >= 3: | |||
| if sys.version_info[0] == 3 and sys.version_info[1] >= 6: | |||
There was a problem hiding this comment.
Sure. Claim supporting 3.5 might need extra efforts.
#21954 introduced files using f-strings and type annotations guarded by an interpreter version check. That version check was not stringent enough.
What's more, it turns out we don't have presubmit tests for Python 3.5. #22546 includes reports of users of 3.5 failing to import
grpc.experimental.