Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Add ChannelCredentials.SecureSsl property for better codecompletion with ChannelCredentials #26472

Merged
merged 4 commits into from
Jun 24, 2021
Merged

[C#] Add ChannelCredentials.SecureSsl property for better codecompletion with ChannelCredentials #26472

merged 4 commits into from
Jun 24, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 12, 2021 •
edited
Loading

Adds ChannelCredentials.Secure. The same as using new SslCredentials().

I want to add this as grpc-dotnet only cares about new SslCredentials() and ChannelCredentials.Secure is much more discoverable via intellisense.

Grpc.Core users can use the new property if they wish. Doc comment mentions that SslCredentials should be used if they want to customize the credentials.

@jtattermusch

@JamesNK JamesNK changed the title Add ChannelCredentials.Secure [C#] Add ChannelCredentials.Secure Jun 12, 2021
@jtattermusch
Copy link
Contributor

The tests are actually failing:
https://source.cloud.google.com/results/invocations/8d7f7447-97c0-48e4-90f3-10f324d2be56/targets/github%2Fgrpc%2Frun_tests%2Fcsharp_windows_dbg_native_default_coreclr%2Fcsharp.Grpc.Core.Tests.ChannelCredentialsTest/tests

jtattermusch
jtattermusch reviewed Jun 18, 2021
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea sounds fine, I'll approve after the comments are addressed.

src/csharp/Grpc.Core.Tests/ChannelCredentialsTest.cs Outdated Show resolved Hide resolved
src/csharp/Grpc.Core.Tests/ChannelCredentialsTest.cs Outdated Show resolved Hide resolved
src/csharp/Grpc.Core.Api/ChannelCredentials.cs Outdated Show resolved Hide resolved
src/csharp/Grpc.Core.Api/ChannelCredentials.cs Outdated Show resolved Hide resolved
@JamesNK JamesNK force-pushed the jamesnk/channelcredentials-secure branch from 7e6fd9e to 11a7da4 Compare June 23, 2021 19:13
@jtattermusch jtattermusch added the release notes: yes Indicates if PR needs to be in release notes label Jun 24, 2021
@jtattermusch jtattermusch changed the title [C#] Add ChannelCredentials.Secure [C#] Add ChannelCredentials.SecureSsl property for better codecompletion with ChannelCredentials Jun 24, 2021
@jtattermusch
Copy link
Contributor

The test failures are caused by
#26522

@jtattermusch jtattermusch enabled auto-merge (squash) June 24, 2021 09:39
jtattermusch
jtattermusch approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jtattermusch jtattermusch merged commit 2537957 into grpc:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees
No one assigned
Labels
lang/C# release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @jtattermusch