Fix redundant error unref in finish_accept in tcp_server_custom #26750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
added
lang/node
lang/core
release notes: no
nicolasnoble
approved these changes
Jul 21, 2021
This was referenced Jul 25, 2021
This was referenced Jul 26, 2021
kodiakhq bot
pushed a commit
to relaycorp/awala-gateway-internet
that referenced
this pull request
Jul 26, 2021
Bumps [grpc](https://github.com/grpc/grpc-node) from 1.24.10 to 1.24.11. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-node/releases">grpc's releases</a>.</em></p> <blockquote> <h2>Node gRPC 1.24.11</h2> <ul> <li><strong>SECURITY FIX</strong>: Fix a double free bug in server-side TCP error handling code (grpc/grpc#26750 picked up in <a href="https://github-redirect.dependabot.com/grpc/grpc-node/issues/1861">#1861</a>). This bug was discovered by Brad Buckingham and Alex Skwarczynski.</li> <li>Update the <code>ServiceDefinition</code> TypeScript type for compatibility with <code>@grpc/grpc-js</code> (<a href="https://github-redirect.dependabot.com/grpc/grpc-node/issues/1860">#1860</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/grpc/grpc-node/commit/39680a5084f4c0c0b98370a5d61edda65dbfe026"><code>39680a5</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/grpc/grpc-node/issues/1861">#1861</a> from murgatroid99/grpc-native_submodule_bump</li> <li><a href="https://github.com/grpc/grpc-node/commit/bb518305751e577ef05abfc11362ebd2cc5de3b2"><code>bb51830</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/grpc/grpc-node/issues/1860">#1860</a> from murgatroid99/grpc-native_ServiceDefinition_fix</li> <li><a href="https://github.com/grpc/grpc-node/commit/cd825350128c5aed2a97845160df1d91e6fc0f26"><code>cd82535</code></a> grpc-native: Update submodule and version</li> <li><a href="https://github.com/grpc/grpc-node/commit/913734dd588eda89c71f06cadc4f7066477a273b"><code>913734d</code></a> grpc: Make ServiceDefinition type argument optional</li> <li>See full diff in <a href="https://github.com/grpc/grpc-node/compare/grpc@1.24.10...grpc@1.24.11">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced Apr 4, 2022
This was referenced Apr 19, 2022
This was referenced Apr 29, 2022
This was referenced May 16, 2022
This was referenced May 29, 2022
This was referenced Jun 7, 2022
This was referenced Jun 20, 2022
Merged
This was referenced Jul 2, 2022
This was referenced Jul 13, 2022
This was referenced Aug 7, 2022
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPC_LOG_IF_ERRORalready callsGRPC_ERROR_UNREF, so there is no need to call it again.