Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry example for gRPC Python #26829

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Conversation

lidizheng
Copy link
Contributor

As title.

Line options.append(("grpc.enable_retries", 1)) is needed today for users to test on v1.39.0. We can remove it after v1.40.0 is released, or comment it after v1.40.0.

@lidizheng lidizheng added area/documentation lang/Python release notes: yes Indicates if PR needs to be in release notes labels Jul 29, 2021
@lidizheng lidizheng requested a review from gnossen July 29, 2021 20:38
Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome finally seeing automatic retries added. Thanks for the additional example!

examples/python/retry/async_retry_client.py Show resolved Hide resolved
examples/python/retry/helloworld.proto Outdated Show resolved Hide resolved
@lidizheng
Copy link
Contributor Author

Known failures #26595

@lidizheng lidizheng merged commit 6c6463e into grpc:master Jul 30, 2021
Vignesh2208 pushed a commit to Vignesh2208/grpc that referenced this pull request Aug 20, 2021
* Add retry example for gRPC Python

* Make sanity test happy && simplfy proto definition

* Fix a grammer issue
lidizheng added a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
* Add retry example for gRPC Python

* Make sanity test happy && simplfy proto definition

* Fix a grammer issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation lang/Python release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants