[Ruby] Fix memory leak in GRPC::Core::Call#run_batch #27900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtattermusch @apolcyn is there any chance this will be reviewed or merged soon? Thank you! |
The C function that backs this Ruby method can raise a variety of errors. In particular, grpc_run_batch_stack_fill_ops has a lot of places that raise errors. When an error is raised, allocated memory (e.g. run_batch_stack) is not freed and is permanently leaked. This changes grpc_rb_call_run_batch to have an ensure block to perform cleanup and free all allocated resources.
peterzhu2118
force-pushed
the
pz-run-batch-mem-leak
branch
from
6d3d5aa
to
1e96b1a
Compare
|
@apolcyn needs to review this. |
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
|
@apolcyn could I get a review on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C function that backs this Ruby method can raise a variety of errors. In particular, grpc_run_batch_stack_fill_ops has a lot of places that raise errors. When an error is raised, allocated memory (e.g. run_batch_stack) is not freed and is permanently leaked.
This changes grpc_rb_call_run_batch to have an ensure block to perform cleanup and free all allocated resources.
@yashykt