[Ruby] Fix memory leak in GRPC::Core::Call#run_batch #27900
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C function that backs this Ruby method can raise a variety of errors. In particular, grpc_run_batch_stack_fill_ops has a lot of places that raise errors. When an error is raised, allocated memory (e.g. run_batch_stack) is not freed and is permanently leaked.
This changes grpc_rb_call_run_batch to have an ensure block to perform cleanup and free all allocated resources.
@yashykt