Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NetBSD support (Community-supported) #29542

Merged
merged 3 commits into from
May 23, 2022
Merged

Add NetBSD support (Community-supported) #29542

merged 3 commits into from
May 23, 2022

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented Apr 30, 2022

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 30, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 0-wiz-0 / name: Thomas Klausner (2ecd903)

@drfloob
Copy link
Member

drfloob commented May 19, 2022

@0-wiz-0 thanks for the contribution. NetBSD would be a community-supported platform with this addition, which entails a few things. The gRPC team doesn't have the resources to test or develop on NetBSD, so support may be broken at any time without us knowing, or without us being able to spend cycles fixing it. We're generally ok to allow these sorts of improvements, but that has to be taken into consideration.

As for changes to the PR: Going forward, we request a platform owner to add their contact information to port_platform.h so that in the event of a problem, it's clear who to reach out to. You should also update https://github.com/grpc/grpc/blob/master/src/cpp/README.md to add NetBSD to the list of community-supported platforms.

@drfloob drfloob changed the title Add NetBSD support Add NetBSD support (Community-supported) May 19, 2022
@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented May 19, 2022

Thanks for the feedback, @drfloob ! I've added NetBSD to the README.md, but I didn't find prior art on how to add contact information for NetBSD (I looked for a FreeBSD contact and found none). Can you please specify this part more explicitly? Thanks.

@drfloob
Copy link
Member

drfloob commented May 19, 2022 •
edited
Loading

I'd recommend something like:

// NetBSD is a community-supported platform. Please contact Jane Q. Public <developer@example.com> for support.

FreeBSD support was added a good long while ago, and it's unfortunate there's no PoC for platform support. This new requirement is partially in response to some challenges there.

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented May 20, 2022

I have added a comment as suggested, thanks.

@drfloob drfloob added the release notes: yes Indicates if PR needs to be in release notes label May 23, 2022
@drfloob
Copy link
Member

drfloob commented May 23, 2022

Looks good, thanks for the contribution @0-wiz-0!

@drfloob drfloob merged commit 0637724 into grpc:master May 23, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label May 24, 2022
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request May 24, 2022
@0-wiz-0 @lidizheng
Add NetBSD support (Community-supported) (grpc#29542)
5f292b7 
* Add NetBSD support

* Add NetBSD to platforms list as 'Community Supported'

* Add contact email for issues with the NetBSD port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drfloob drfloob drfloob approved these changes

Assignees

@drfloob drfloob

Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0-wiz-0 @drfloob @grpc-kokoro