-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compatibility with the new custom kokoro win2019 image #32649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
added
the
release notes: no
Indicates if PR should not be in release notes
label
Mar 17, 2023
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
Mar 17, 2023
veblush
approved these changes
Mar 17, 2023
jtattermusch
force-pushed
the
win2019_experiments
branch
from
March 20, 2023 09:56
2356ae0
to
5675390
Compare
The ObjC tests and Android tests seem unrelated to this PR (and they happen on master as well). |
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Mar 20, 2023
…2649) Fix incompatibilities identified when running adhoc runs on the new custom win2019 image. After merging this, it should be possible to switch to the new image without breaking any tests. - for most fixes I added a comment that explains why they're necessary. - the new image won't have VS2015 installed, so I'm switching the protoc artifact build to VS2017 This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting). After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019.
This was referenced Mar 20, 2023
Merged
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
Mar 20, 2023
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Mar 24, 2023
(part of removing support for VS2017) Also see grpc#32649 Also see grpc#32615 The switch to grpc-win2019 windows workers has already happened: (cl/517400022). Once this PR lands, I'll backport to 1.53.x branch as well (since that release removes the VS2017 support).
jtattermusch
added a commit
that referenced
this pull request
Apr 5, 2023
Followup for #32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Apr 5, 2023
Followup for grpc#32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Apr 5, 2023
Followup for grpc#32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…2649) Fix incompatibilities identified when running adhoc runs on the new custom win2019 image. After merging this, it should be possible to switch to the new image without breaking any tests. - for most fixes I added a comment that explains why they're necessary. - the new image won't have VS2015 installed, so I'm switching the protoc artifact build to VS2017 This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting). After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
(part of removing support for VS2017) Also see grpc#32649 Also see grpc#32615 The switch to grpc-win2019 windows workers has already happened: (cl/517400022). Once this PR lands, I'll backport to 1.53.x branch as well (since that release removes the VS2017 support).
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
Followup for grpc#32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
May 9, 2023
…2649) Fix incompatibilities identified when running adhoc runs on the new custom win2019 image. After merging this, it should be possible to switch to the new image without breaking any tests. - for most fixes I added a comment that explains why they're necessary. - the new image won't have VS2015 installed, so I'm switching the protoc artifact build to VS2017 This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting). After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019.
veblush
added a commit
that referenced
this pull request
May 9, 2023
…2019 image (#32649) (#33052) Fix incompatibilities identified when running adhoc runs on the new custom win2019 image. After merging this, it should be possible to switch to the new image without breaking any tests. - for most fixes I added a comment that explains why they're necessary. - the new image won't have VS2015 installed, so I'm switching the protoc artifact build to VS2017 This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting). After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019. --------- Co-authored-by: Jan Tattermusch <jtattermusch@google.com> Co-authored-by: Esun Kim <veblush@google.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Fix incompatibilities identified when running adhoc runs on the new custom win2019 image. After merging this, it should be possible to switch to the new image without breaking any tests. - for most fixes I added a comment that explains why they're necessary. - the new image won't have VS2015 installed, so I'm switching the protoc artifact build to VS2017 This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting). After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Followup for #32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
imported
Specifies if the PR has been imported to the internal repository
lang/C#
lang/Python
per-call-memory/neutral
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incompatibilities identified when running adhoc runs on the new custom win2019 image.
After merging this, it should be possible to switch to the new image without breaking any tests.
This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting).
After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019.