[test-infra] Re-enable skipped windows tests #32658

jtattermusch · 2023-03-20T10:18:15Z

Followup for #32649 (which disabled the tests mentioned below).
Also sets correct path for tests build by ninja on windows, so that they don't get skipped.

Once merged, I'll backport to 1.54.x and 1.53.x

The original issue with tests being skipped.

+ python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs
2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat

2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0]

2023-03-20 08:04:52,434 detected port server running version 21

2023-03-20 08:04:52,672 my port server is version 21

2023-03-20 08:04:52,703 SUCCESS: All tests passed



WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe



WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe



WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe



WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe



WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe



WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe



WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe



WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe

jtattermusch · 2023-03-31T08:15:34Z

Bad server response test

2023-03-20 19:03:53,088 D0320 19:03:51.818000000  1968 test_config.cc:132] test slowdown factor: sanitizer=1, fixture=1, poller=1, total=1

D0320 19:03:51.818000000  1968 config.cc:119] gRPC EXPERIMENT tcp_frame_size_tuning               OFF (default:OFF)

D0320 19:03:51.818000000  1968 config.cc:119] gRPC EXPERIMENT tcp_rcv_lowat                       OFF (default:OFF)

D0320 19:03:51.818000000  1968 config.cc:119] gRPC EXPERIMENT peer_state_based_framing            OFF (default:OFF)

D0320 19:03:51.818000000  1968 config.cc:119] gRPC EXPERIMENT flow_control_fixes                  ON  (default:ON)

D0320 19:03:51.818000000  1968 config.cc:119] gRPC EXPERIMENT memory_pressure_controller          OFF (default:OFF)

D0320 19:03:51.819000000  1968 config.cc:119] gRPC EXPERIMENT unconstrained_max_quota_buffer_size OFF (default:OFF)

D0320 19:03:51.819000000  1968 config.cc:119] gRPC EXPERIMENT event_engine_client                 OFF (default:OFF)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT monitoring_experiment               ON  (default:ON)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT promise_based_client_call           OFF (default:OFF)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT free_large_allocator                OFF (default:OFF)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT promise_based_server_call           OFF (default:OFF)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT transport_supplies_client_latency   OFF (default:OFF)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT event_engine_listener               OFF (default:OFF)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT schedule_cancellation_over_write    OFF (default:OFF)

D0320 19:03:51.820000000  1968 config.cc:119] gRPC EXPERIMENT trace_record_callops                OFF (default:OFF)

D0320 19:03:51.823000000  1968 dns_resolver_ares.cc:823] Using ares dns resolver

D0320 19:03:51.826000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "priority_experimental"

D0320 19:03:51.826000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "outlier_detection_experimental"

D0320 19:03:51.827000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "weighted_target_experimental"

D0320 19:03:51.827000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "pick_first"

D0320 19:03:51.827000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "round_robin"

D0320 19:03:51.827000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "weighted_round_robin_experimental"

D0320 19:03:51.827000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "ring_hash_experimental"

D0320 19:03:51.828000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "grpclb"

D0320 19:03:51.829000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "rls_experimental"

D0320 19:03:51.830000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_manager_experimental"

D0320 19:03:51.830000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_impl_experimental"

D0320 19:03:51.830000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "cds_experimental"

D0320 19:03:51.831000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_resolver_experimental"

D0320 19:03:51.831000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "xds_override_host_experimental"

D0320 19:03:51.831000000  1968 lb_policy_registry.cc:46] registering LB policy factory for "xds_wrr_locality_experimental"

D0320 19:03:51.831000000  1968 certificate_provider_registry.cc:35] registering certificate provider factory for "file_watcher"

I0320 19:03:52.863000000  1968 test_tcp_server.cc:92] test tcp server listening on 0.0.0.0:11011

D0320 19:03:52.866000000  3644 bad_server_response_test.cc:295] done=0, time_left=5.000000000

D0320 19:03:52.866000000  3644 bad_server_response_test.cc:295] done=0, time_left=5.000000000

D0320 19:03:52.875000000  3644 bad_server_response_test.cc:295] done=0, time_left=4.991000000

D0320 19:03:52.879000000  1968 bad_server_response_test.cc:142] Server received: 50 52 49 20 2a 20 48 54 54 50 2f 32 2e 30 0d 0a 0d 0a 53 4d 0d 0a 0d 0a 00 00 24 04 00 00 00 00 00 00 02 00 00 00 00 00 03 00 00 00 00 00 04 00 40 00 00 00 05 00 40 00 00 00 06 00 00 20 00 fe 03 00 00 00 01 00 00 04 08 00 00 00 00 00 00 3f 00 01 'PRI * HTTP/2.0....SM......$.....................@.....@...... .................?..'

D0320 19:03:52.879000000  3644 bad_server_response_test.cc:295] done=0, time_left=4.987000000

D0320 19:03:52.879000000  1968 bad_server_response_test.cc:146] got 82 bytes, expected 200 bytes or a non-HTTP2 response to be sent

D0320 19:03:52.879000000  1968 bad_server_response_test.cc:142] Server received: 00 00 00 04 01 00 00 00 00 00 00 c6 01 04 00 00 00 01 40 05 3a 70 61 74 68 0f 2f 53 65 72 76 69 63 65 2f 4d 65 74 68 6f 64 40 0a 3a 61 75 74 68 6f 72 69 74 79 09 6c 6f 63 61 6c 68 6f 73 74 83 86 40 0c 63 6f 6e 74 65 6e 74 2d 74 79 70 65 10 61 70 70 6c 69 63 61 74 69 6f 6e 2f 67 72 70 63 40 02 74 65 08 74 72 61 69 6c 65 72 73 40 14 67 72 70 63 2d 61 63 63 65 70 74 2d 65 6e 63 6f 64 69 6e 67 17 69 64 65 6e 74 69 74 79 2c 20 64 65 66 6c 61 74 65 2c 20 67 7a 69 70 40 0c 67 72 70 63 2d 74 69 6d 65 6f 75 74 02 35 53 40 0a 75 73 65 72 2d 61 67 65 6e 74 1f 67 72 70 63 2d 63 2f 33 30 2e 31 2e 30 20 28 77 69 6e 64 6f 77 73 3b 20 63 68 74 74 70 32 29 00 00 00 00 01 00 00 00 01 '..................@.:path./Service/Method@.:authority.localhost..@.content-type.application/grpc@.te.trailers@.grpc-accept-encoding.identity, deflate, gzip@.grpc-timeout.5S@.user-agent.grpc-c/30.1.0 (windows; chttp2).........'

D0320 19:03:52.879000000  1968 bad_server_response_test.cc:146] got 307 bytes, expected 200 bytes or a non-HTTP2 response to be sent

D0320 19:03:52.879000000  3644 bad_server_response_test.cc:295] done=1, time_left=4.987000000


2023-03-20 19:03:53,088 FAILED: cmake/build/bad_server_response_test.exe [ret=3221225477, pid=5596, time=1.4sec]

jtattermusch · 2023-03-31T08:16:06Z

Goaway server test

2023-03-20 19:03:57,801 D0320 19:03:51.529000000  4652 test_config.cc:132] test slowdown factor: sanitizer=1, fixture=1, poller=1, total=1

D0320 19:03:51.530000000  4652 config.cc:119] gRPC EXPERIMENT tcp_frame_size_tuning               OFF (default:OFF)

D0320 19:03:51.530000000  4652 config.cc:119] gRPC EXPERIMENT tcp_rcv_lowat                       OFF (default:OFF)

D0320 19:03:51.530000000  4652 config.cc:119] gRPC EXPERIMENT peer_state_based_framing            OFF (default:OFF)

D0320 19:03:51.530000000  4652 config.cc:119] gRPC EXPERIMENT flow_control_fixes                  ON  (default:ON)

D0320 19:03:51.530000000  4652 config.cc:119] gRPC EXPERIMENT memory_pressure_controller          OFF (default:OFF)

D0320 19:03:51.530000000  4652 config.cc:119] gRPC EXPERIMENT unconstrained_max_quota_buffer_size OFF (default:OFF)

D0320 19:03:51.531000000  4652 config.cc:119] gRPC EXPERIMENT event_engine_client                 OFF (default:OFF)

D0320 19:03:51.531000000  4652 config.cc:119] gRPC EXPERIMENT monitoring_experiment               ON  (default:ON)

D0320 19:03:51.531000000  4652 config.cc:119] gRPC EXPERIMENT promise_based_client_call           OFF (default:OFF)

D0320 19:03:51.531000000  4652 config.cc:119] gRPC EXPERIMENT free_large_allocator                OFF (default:OFF)

D0320 19:03:51.532000000  4652 config.cc:119] gRPC EXPERIMENT promise_based_server_call           OFF (default:OFF)

D0320 19:03:51.532000000  4652 config.cc:119] gRPC EXPERIMENT transport_supplies_client_latency   OFF (default:OFF)

D0320 19:03:51.532000000  4652 config.cc:119] gRPC EXPERIMENT event_engine_listener               OFF (default:OFF)

D0320 19:03:51.532000000  4652 config.cc:119] gRPC EXPERIMENT schedule_cancellation_over_write    OFF (default:OFF)

D0320 19:03:51.532000000  4652 config.cc:119] gRPC EXPERIMENT trace_record_callops                OFF (default:OFF)

D0320 19:03:51.537000000  4652 dns_resolver_ares.cc:823] Using ares dns resolver

D0320 19:03:51.544000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "priority_experimental"

D0320 19:03:51.544000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "outlier_detection_experimental"

D0320 19:03:51.544000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "weighted_target_experimental"

D0320 19:03:51.545000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "pick_first"

D0320 19:03:51.545000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "round_robin"

D0320 19:03:51.545000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "weighted_round_robin_experimental"

D0320 19:03:51.545000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "ring_hash_experimental"

D0320 19:03:51.546000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "grpclb"

D0320 19:03:51.547000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "rls_experimental"

D0320 19:03:51.548000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_manager_experimental"

D0320 19:03:51.548000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_impl_experimental"

D0320 19:03:51.549000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "cds_experimental"

D0320 19:03:51.549000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_resolver_experimental"

D0320 19:03:51.549000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "xds_override_host_experimental"

D0320 19:03:51.549000000  4652 lb_policy_registry.cc:46] registering LB policy factory for "xds_wrr_locality_experimental"

D0320 19:03:51.549000000  4652 certificate_provider_registry.cc:35] registering certificate provider factory for "file_watcher"


2023-03-20 19:03:57,801 FAILED: cmake/build/goaway_server_test.exe [ret=3221226505, pid=3520, time=6.4sec]

jtattermusch · 2023-03-31T08:16:50Z

Invalid call argument test

2023-03-20 19:04:16,537 D0320 19:03:51.892000000  1648 test_config.cc:132] test slowdown factor: sanitizer=1, fixture=1, poller=1, total=1

D0320 19:03:51.893000000  1648 config.cc:119] gRPC EXPERIMENT tcp_frame_size_tuning               OFF (default:OFF)

D0320 19:03:51.893000000  1648 config.cc:119] gRPC EXPERIMENT tcp_rcv_lowat                       OFF (default:OFF)

D0320 19:03:51.893000000  1648 config.cc:119] gRPC EXPERIMENT peer_state_based_framing            OFF (default:OFF)

D0320 19:03:51.893000000  1648 config.cc:119] gRPC EXPERIMENT flow_control_fixes                  ON  (default:ON)

D0320 19:03:51.893000000  1648 config.cc:119] gRPC EXPERIMENT memory_pressure_controller          OFF (default:OFF)

D0320 19:03:51.893000000  1648 config.cc:119] gRPC EXPERIMENT unconstrained_max_quota_buffer_size OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT event_engine_client                 OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT monitoring_experiment               ON  (default:ON)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT promise_based_client_call           OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT free_large_allocator                OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT promise_based_server_call           OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT transport_supplies_client_latency   OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT event_engine_listener               OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT schedule_cancellation_over_write    OFF (default:OFF)

D0320 19:03:51.894000000  1648 config.cc:119] gRPC EXPERIMENT trace_record_callops                OFF (default:OFF)

D0320 19:03:51.898000000  1648 dns_resolver_ares.cc:823] Using ares dns resolver

I0320 19:03:51.899000000  1648 invalid_call_argument_test.cc:604] test_invalid_initial_metadata_reserved_key

D0320 19:03:51.901000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "priority_experimental"

D0320 19:03:51.901000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "outlier_detection_experimental"

D0320 19:03:51.901000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "weighted_target_experimental"

D0320 19:03:51.901000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "pick_first"

D0320 19:03:51.902000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "round_robin"

D0320 19:03:51.902000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "weighted_round_robin_experimental"

D0320 19:03:51.902000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "ring_hash_experimental"

D0320 19:03:51.903000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "grpclb"

D0320 19:03:51.903000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "rls_experimental"

D0320 19:03:51.904000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_manager_experimental"

D0320 19:03:51.904000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_impl_experimental"

D0320 19:03:51.905000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "cds_experimental"

D0320 19:03:51.905000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "xds_cluster_resolver_experimental"

D0320 19:03:51.905000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "xds_override_host_experimental"

D0320 19:03:51.905000000  1648 lb_policy_registry.cc:46] registering LB policy factory for "xds_wrr_locality_experimental"

D0320 19:03:51.905000000  1648 certificate_provider_registry.cc:35] registering certificate provider factory for "file_watcher"

E0320 19:03:52.929000000  1648 call.cc:997] validate_metadata: UNKNOWN:Metadata keys cannot start with : {file:"T:\\altsrc\\github\\grpc\\workspace_c_windows_dbg_native\\src\\core\\lib\\surface\\validate_metadata.cc", file_line:84, created_time:"2023-03-20T19:03:52.928347139+00:00"}

I0320 19:03:52.931000000  1648 invalid_call_argument_test.cc:156] test_non_null_reserved_on_start_batch

I0320 19:03:53.972000000  1648 invalid_call_argument_test.cc:166] test_non_null_reserved_on_op

I0320 19:03:54.989000000  1648 invalid_call_argument_test.cc:185] test_send_initial_metadata_more_than_once

I0320 19:03:56.088000000  1648 invalid_call_argument_test.cc:217] test_too_many_metadata

I0320 19:03:57.106000000  1648 invalid_call_argument_test.cc:236] test_send_null_message

I0320 19:03:58.122000000  1648 invalid_call_argument_test.cc:260] test_send_messages_at_the_same_time

I0320 19:03:59.156000000  1648 invalid_call_argument_test.cc:294] test_send_server_status_from_client

I0320 19:04:00.186000000  1648 invalid_call_argument_test.cc:316] test_receive_initial_metadata_twice_at_client

I0320 19:04:06.224000000  1648 invalid_call_argument_test.cc:348] test_receive_message_with_invalid_flags

I0320 19:04:07.264000000  1648 invalid_call_argument_test.cc:367] test_receive_two_messages_at_the_same_time

I0320 19:04:08.296000000  1648 invalid_call_argument_test.cc:391] test_recv_close_on_server_from_client

I0320 19:04:09.328000000  1648 invalid_call_argument_test.cc:410] test_recv_status_on_client_twice

I0320 19:04:15.350000000  1648 invalid_call_argument_test.cc:447] test_send_close_from_client_on_server


2023-03-20 19:04:16,537 FAILED: cmake/build/invalid_call_argument_test.exe [ret=3221226505, pid=2888, time=24.7sec]

jtattermusch · 2023-03-31T08:19:40Z

@veblush @yashykt I'd be grateful for any insights why the windows tests above keep failing.

they work when built with bazel RBE
due to a glitch in run_tests.py, they haven't run for quite a while since run_tests.py was getting the location of the .exe wrong and thus the tests were being skipped (for quite a long time).

jtattermusch · 2023-04-04T11:19:28Z

I'll have to doublecheck, but it seems that the 3 tests that were failing started passing again (likely thanks to #32764)

jtattermusch · 2023-04-04T18:00:37Z

I'll have to doublecheck, but it seems that the 3 tests that were failing started passing again (likely thanks to #32764)

Hmm or they don't exist anymore?

jtattermusch · 2023-04-05T08:33:28Z

I'll have to doublecheck, but it seems that the 3 tests that were failing started passing again (likely thanks to #32764)

Hmm or they don't exist anymore?

Ok, I investigated and it seem that https://github.com/grpc/grpc/pull/32603/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a has moved

invalid_call_argument_test, bad_server_response_test and goaway_server_test from C tests to CXX tests, so they're not being run by "Basic Tests C Windows". That's actually fine and explicitly excluding the tests in run_tests.py doesn't make any sense anymore - so I'll go ahead and merge this PR.

jtattermusch · 2023-04-05T08:37:06Z

FTR Note that this PR still results in running some ninja-built tests that were previously skipped.
e.g.

2023-04-04 11:21:30,260 START: cmake/build/pollset_windows_starvation_test.exe

2023-04-04 11:21:30,323 START: cmake/build/multiple_server_queues_test.exe

2023-04-04 11:21:30,385 START: cmake/build/public_headers_must_be_c89.exe

2023-04-04 11:21:30,447 START: cmake/build/test_core_iomgr_timer_list_test.exe GRPC_POLL_STRATEGY=none

2023-04-04 11:21:30,572 PASSED: cmake/build/public_headers_must_be_c89.exe [time=0.2sec, retries=0:0]

2023-04-04 11:21:30,572 PASSED: cmake/build/pollset_windows_starvation_test.exe [time=0.3sec, retries=0:0]

2023-04-04 11:21:30,572 PASSED: cmake/build/multiple_server_queues_test.exe [time=0.2sec, retries=0:0]

2023-04-04 11:21:30,682 PASSED: cmake/build/test_core_iomgr_timer_list_test.exe GRPC_POLL_STRATEGY=none [time=0.2sec, retries=0:0]

Followup for grpc#32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```

Backports #32764, #32777 and #32658

Followup for grpc#32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```

Followup for #32649 (which disabled the tests mentioned below). Also sets correct path for tests build by ninja on windows, so that they don't get skipped. Once merged, I'll backport to 1.54.x and 1.53.x The original issue with tests being skipped. ``` + python3 workspace_c_windows_dbg_native/tools/run_tests/run_tests.py -t -j 8 -x run_tests/c_windows_dbg_native/sponge_log.xml --report_suite_name c_windows_dbg_native -l c -c dbg --iomgr_platform native --bq_result_table aggregate_results --measure_cpu_costs 2023-03-20 07:56:53,523 START: tools\run_tests\helper_scripts\build_cxx.bat 2023-03-20 08:04:51,388 PASSED: tools\run_tests\helper_scripts\build_cxx.bat [time=477.9sec, retries=0:0; cpu_cost=0.0; estimated=1.0] 2023-03-20 08:04:52,434 detected port server running version 21 2023-03-20 08:04:52,672 my port server is version 21 2023-03-20 08:04:52,703 SUCCESS: All tests passed WARNING: binary not found, skipping cmake/build/Debug/bad_server_response_test.exe WARNING: binary not found, skipping cmake/build/Debug/connection_refused_test.exe WARNING: binary not found, skipping cmake/build/Debug/goaway_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/invalid_call_argument_test.exe WARNING: binary not found, skipping cmake/build/Debug/multiple_server_queues_test.exe WARNING: binary not found, skipping cmake/build/Debug/no_server_test.exe WARNING: binary not found, skipping cmake/build/Debug/pollset_windows_starvation_test.exe WARNING: binary not found, skipping cmake/build/Debug/public_headers_must_be_c89.exe ```

github-actions bot added the lang/Python label Mar 20, 2023

grpc-checks bot added bloat/none per-call-memory/neutral per-channel-memory/neutral labels Mar 20, 2023

jtattermusch force-pushed the ninja_improvements branch from 1b5b4be to c4cb45d Compare March 20, 2023 16:29

jtattermusch added the kokoro:force-run label Mar 20, 2023

grpc-kokoro removed kokoro:force-run labels Mar 20, 2023

jtattermusch changed the title ~~add TODO for ninja tests on windows~~ Re-enable skipped windows tests Mar 21, 2023

jtattermusch added the release notes: no Indicates if PR should not be in release notes label Apr 4, 2023

github-actions bot added the PR title format label Apr 4, 2023

jtattermusch added 2 commits April 4, 2023 13:12

reenable windows tests

ee07b60

run win tests under ninja

0be11d8

jtattermusch force-pushed the ninja_improvements branch from c4cb45d to 0be11d8 Compare April 4, 2023 11:12

jtattermusch marked this pull request as ready for review April 4, 2023 11:17

jtattermusch requested a review from veblush April 4, 2023 11:17

jtattermusch assigned veblush Apr 4, 2023

jtattermusch changed the title ~~Re-enable skipped windows tests~~ [test-infra] Re-enable skipped windows tests Apr 4, 2023

github-actions bot removed the PR title format label Apr 4, 2023

veblush approved these changes Apr 4, 2023

View reviewed changes

jtattermusch merged commit a6c723d into grpc:master Apr 5, 2023

jtattermusch mentioned this pull request Apr 5, 2023

[cmake] Backport VS2019 fixes to 1.54.x branch #32804

Merged

jtattermusch mentioned this pull request Apr 5, 2023

[cmake] Backport VS2019 fixes to 1.53.x branch #32805

Merged

copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Apr 5, 2023

jtattermusch added a commit that referenced this pull request Apr 6, 2023

[cmake] Backport VS2019 fixes to 1.54.x branch (#32804)

7b177e8

Backports #32764, #32777 and #32658

veblush pushed a commit that referenced this pull request Apr 13, 2023

[cmake] Backport VS2019 fixes to 1.53.x branch (#32805)

3c16bf1

Backports #32764, #32777 and #32658

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test-infra] Re-enable skipped windows tests #32658

[test-infra] Re-enable skipped windows tests #32658

jtattermusch commented Mar 20, 2023 •

edited

Loading

jtattermusch commented Mar 31, 2023

jtattermusch commented Mar 31, 2023

jtattermusch commented Mar 31, 2023

jtattermusch commented Mar 31, 2023

jtattermusch commented Apr 4, 2023

jtattermusch commented Apr 4, 2023

jtattermusch commented Apr 5, 2023

jtattermusch commented Apr 5, 2023

[test-infra] Re-enable skipped windows tests #32658

[test-infra] Re-enable skipped windows tests #32658

Conversation

jtattermusch commented Mar 20, 2023 • edited Loading

jtattermusch commented Mar 31, 2023

jtattermusch commented Mar 31, 2023

jtattermusch commented Mar 31, 2023

jtattermusch commented Mar 31, 2023

jtattermusch commented Apr 4, 2023

jtattermusch commented Apr 4, 2023

jtattermusch commented Apr 5, 2023

jtattermusch commented Apr 5, 2023

jtattermusch commented Mar 20, 2023 •

edited

Loading