[cmake] improved stdalign.h workaround for windows build #32777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
added
the
release notes: no
|
Adhoc windows/grpc_portability run http://sponge/68f4cc3e-9e17-4cd4-9b28-48bc97e3eb87 |
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
davidben
reviewed
Apr 3, 2023
| @rem Always use the newest Windows 10 SDK available. | ||
| @rem A new-enough Windows 10 SDK that supports C++11's stdalign.h is required | ||
| @rem for a successful build. | ||
| @rem For some reason, by default cmake together with visual studio generator |
There was a problem hiding this comment.
Nit: Can probably rephrase the "For some reason" bit now, since we know why it's happening. (It prefers the Windows 10 SDK whose version number happens to match the host OS's version number.)
jtattermusch
force-pushed
the
followup_32764
branch
from
dc44d88
to
70c622c
Compare
|
BTW, won't help us until it's released and such, but future CMake should hopefully be better here. |
veblush
approved these changes
Apr 4, 2023
|
Bump to kick the title check. |
jtattermusch
force-pushed
the
followup_32764
branch
from
70c622c
to
d84899e
Compare
jtattermusch
changed the title
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Apr 5, 2023
Improved the workaround from grpc#32764 as suggested in grpc#32764 (comment). Once merged, I'll backport to 1.54.x and 1.53.x together with grpc#32764 (these have switched to VS2019)
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Apr 5, 2023
Improved the workaround from grpc#32764 as suggested in grpc#32764 (comment). Once merged, I'll backport to 1.54.x and 1.53.x together with grpc#32764 (these have switched to VS2019)
copybara-service
bot
added
the
imported
jtattermusch
added a commit
that referenced
this pull request
Apr 6, 2023
veblush
pushed a commit
that referenced
this pull request
Apr 13, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
Improved the workaround from grpc#32764 as suggested in grpc#32764 (comment). Once merged, I'll backport to 1.54.x and 1.53.x together with grpc#32764 (these have switched to VS2019)
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Improved the workaround from #32764 as suggested in #32764 (comment). Once merged, I'll backport to 1.54.x and 1.53.x together with #32764 (these have switched to VS2019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the workaround from #32764 as suggested in #32764 (comment).
Once merged, I'll backport to 1.54.x and 1.53.x together with #32764 (these have switched to VS2019)