Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that no #includes are inside of a namespace. #5547

Merged
merged 3 commits into from
Mar 4, 2016
Merged

Ensure that no #includes are inside of a namespace. #5547

merged 3 commits into from
Mar 4, 2016

Conversation

dgquintas
Copy link
Contributor

Via David Jones. Thanks!

Previously, <sched.h> was #included to grpc::testing. This really is an error,
but it managed to work. Building with C++ modules makes this a much stricter
error, since #inclusions are translated to modular imports.

@vjpai
Copy link
Member

vjpai commented Mar 4, 2016

LGTM. I would merge, except this PR has merge conflicts. Please resolve and I'll merge.

@dgquintas
Copy link
Contributor Author

Done

vjpai added a commit that referenced this pull request Mar 4, 2016
@vjpai
Merge pull request #5547 from dgquintas/limit_cores_includes
647def2 
Ensure that no #includes are inside of a namespace.
@vjpai vjpai merged commit 647def2 into grpc:master Mar 4, 2016
@vjpai vjpai mentioned this pull request Mar 4, 2016
Closed
@ctiller ctiller mentioned this pull request Mar 4, 2016
Merged
@vjpai
Copy link
Member

vjpai commented Mar 4, 2016

We'll need to reopen this after the fixit.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@vjpai vjpai

Labels
area/test cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgquintas @vjpai @googlebot