Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Reimplement Fetch #7

Closed
grtcdr opened this issue Jul 9, 2021 · 1 comment
Closed

Reimplement Fetch #7

grtcdr opened this issue Jul 9, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@grtcdr
Copy link
Owner

grtcdr commented Jul 9, 2021

In version 5.0, the Linux implementation of Fetch was removed so it could be reworked. It will now be reimplemented but with performance in mind.

What must be done different?

  • Fetch::fetch_by_class() in previous versions would create a PCIDevice out of every PCI device it could find, then and only then, does it remove the irrelevant PCI devices, and this costs time and is so inefficient it literally blows my mind why I decided to implement it the way I did.

Nice-To-Haves

  • A new method, something along the lines of Fetch::fetch_by_subclass(name) where name is of type String. This method should return only the PCI devices whose subclass (click any click to see subclasses) is equal to what was provided to the method. It is unmaintainable for me to provide an enum with ready-to-use subclasses, because there's well over 50 of these, and they're always changing.
@grtcdr grtcdr added the bug Something isn't working label Jul 9, 2021
@grtcdr
Copy link
Owner Author

grtcdr commented Jul 12, 2021

#8 solves this

@grtcdr grtcdr closed this as completed Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant